Sign upLogin

cooldaemon/fluent-plugin-sentry-http

View on GitHub
Star

Showing 4 of 4 total issues

Method on_request has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    def on_request(path_info, params)
      begin
        project = @mapping[path_info.split('/')[2]]  # /api/999/store/
        raise 'not found' unless project
      rescue
Severity: Minor
Found in lib/fluent/plugin/in_sentry_http.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method on_request has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def on_request(path_info, params)
      begin
        project = @mapping[path_info.split('/')[2]]  # /api/999/store/
        raise 'not found' unless project
      rescue
Severity: Minor
Found in lib/fluent/plugin/in_sentry_http.rb - About 1 hr to fix

    Method parse has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def parse(text)
        message = Zlib::Inflate.inflate(Base64.decode64(text))
        record = Oj.load(message, :mode => :compat)

        record_time = record['timestamp']
    Severity: Minor
    Found in lib/fluent/plugin/parser_sentry_http.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

          return ['200 OK', {'Content-type' => 'text/plain'}, '']
    Severity: Major
    Found in lib/fluent/plugin/in_sentry_http.rb - About 30 mins to fix
      Severity
      Category
      Status
      Source
      Language