Sign upLogin

cortex-cms/cortex

View on GitHub
Star
app/controllers/cortex/content_items_controller.rb

Summary

Maintainability
A
3 hrs
Test Coverage

TODO found
Open

        # TODO: Should this hit the Plugin Transaction Layer?
Severity: Minor
Found in app/controllers/cortex/content_items_controller.rb by fixme

TODO found
Open

      title = @content_item.field_items.find {|field_item| field_item.field.name == 'Title'}.data['text'] # TODO: refactor this hardcoded Field reference
Severity: Minor
Found in app/controllers/cortex/content_items_controller.rb by fixme

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def create
      create_content_item
        .with_step_args(
          execute_content_item_state_change: [state: params[:content_item][:state]]
        )
Severity: Major
Found in app/controllers/cortex/content_items_controller.rb and 1 other location - About 1 hr to fix
app/controllers/cortex/content_items_controller.rb on lines 37..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def update
      update_content_item
        .with_step_args(
          execute_content_item_state_change: [state: params[:content_item][:state]]
        )
Severity: Major
Found in app/controllers/cortex/content_items_controller.rb and 1 other location - About 1 hr to fix
app/controllers/cortex/content_items_controller.rb on lines 61..80

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Unused block argument - error. You can omit the argument if you don't care about it.
Open

        m.failure do |error|
Severity: Minor
Found in app/controllers/cortex/content_items_controller.rb by rubocop

This cop checks for unused block arguments.

Example:

# bad

do_something do |used, unused|
  puts used
end

do_something do |bar|
  puts :foo
end

define_method(:foo) do |bar|
  puts :baz
end

Example:

#good

do_something do |used, _unused|
  puts used
end

do_something do
  puts :foo
end

define_method(:foo) do |_bar|
  puts :baz
end

Unused block argument - content_item. You can omit the argument if you don't care about it.
Open

        m.success do |content_item|
Severity: Minor
Found in app/controllers/cortex/content_items_controller.rb by rubocop

This cop checks for unused block arguments.

Example:

# bad

do_something do |used, unused|
  puts used
end

do_something do |bar|
  puts :foo
end

define_method(:foo) do |bar|
  puts :baz
end

Example:

#good

do_something do |used, _unused|
  puts used
end

do_something do
  puts :foo
end

define_method(:foo) do |_bar|
  puts :baz
end

Unused block argument - error. You can omit the argument if you don't care about it.
Open

        m.failure do |error|
Severity: Minor
Found in app/controllers/cortex/content_items_controller.rb by rubocop

This cop checks for unused block arguments.

Example:

# bad

do_something do |used, unused|
  puts used
end

do_something do |bar|
  puts :foo
end

define_method(:foo) do |bar|
  puts :baz
end

Example:

#good

do_something do |used, _unused|
  puts used
end

do_something do
  puts :foo
end

define_method(:foo) do |_bar|
  puts :baz
end

Unused block argument - content_item. You can omit the argument if you don't care about it.
Open

        m.success do |content_item|
Severity: Minor
Found in app/controllers/cortex/content_items_controller.rb by rubocop

This cop checks for unused block arguments.

Example:

# bad

do_something do |used, unused|
  puts used
end

do_something do |bar|
  puts :foo
end

define_method(:foo) do |bar|
  puts :baz
end

Example:

#good

do_something do |used, _unused|
  puts used
end

do_something do
  puts :foo
end

define_method(:foo) do |_bar|
  puts :baz
end

There are no issues that match your filters.

Category
Status