Sign upLogin

cosmocode/dokuwiki-plugin-issuelinks

View on GitHub
Star

Showing 899 of 899 total issues

The variable $ID is not named in camelCase.
Open

    public function test_jiralink() {
        // arrange
        global $ID;
        $ID = 'testpage';
        saveWikiText('testpage','[[jira>SPR-281]] [[jira>TW-7]]','test summary');
Severity: Minor
Found in _test/handleIssueLinkSyntax.test.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $pagerev_issues is not named in camelCase.
Open

    public function test_jiralink_oldrev() {
        // arrange
        global $ID, $REV;
        $ID = 'testpage_oldnew';
        saveWikiText($ID,'{{jira>SPR-281}} {{jira>TW-7}}','test summary');
Severity: Minor
Found in _test/handleIssueLinkSyntax.test.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $actual_links is not named in camelCase.
Open

    public function test_parseHTTPLinkHeaders($linkHeader, $expected_links, $msg) {
        /** @var helper_plugin_issuelinks_util $helper*/
        $helper = plugin_load('helper', 'issuelinks_util');

        $actual_links = $helper->parseHTTPLinkHeaders($linkHeader);
Severity: Minor
Found in _test/util.test.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $INPUT is not named in camelCase.
Open

    public function handleAuthorization()
    {
        global $INPUT;

        $token = $INPUT->str('jira_token');
Severity: Minor
Found in services/Jira.service.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $INPUT is not named in camelCase.
Open

    public static function isOurWebhook()
    {
        global $INPUT;
        $userAgent = $INPUT->server->str('HTTP_USER_AGENT');
        return strpos($userAgent, self::WEBHOOK_UA) === 0;
Severity: Minor
Found in services/GitHub.service.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $missing_scopes is not named in camelCase.
Open

    public function isConfigured()
    {
        /** @var \helper_plugin_issuelinks_db $db */
        $db = plugin_load('helper', 'issuelinks_db');
        $authToken = $db->getKeyValue('github_token');
Severity: Minor
Found in services/GitHub.service.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $ID is not named in camelCase.
Open

    public function test_jiralink_oldrev() {
        // arrange
        global $ID, $REV;
        $ID = 'testpage_oldnew';
        saveWikiText($ID,'{{jira>SPR-281}} {{jira>TW-7}}','test summary');
Severity: Minor
Found in _test/handleIssueLinkSyntax.test.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $actual_links is not named in camelCase.
Open

    public function test_parseHTTPLinkHeaders($linkHeader, $expected_links, $msg) {
        /** @var helper_plugin_issuelinks_util $helper*/
        $helper = plugin_load('helper', 'issuelinks_util');

        $actual_links = $helper->parseHTTPLinkHeaders($linkHeader);
Severity: Minor
Found in _test/util.test.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $INPUT is not named in camelCase.
Open

    public function handle()
    {
        global $INPUT;

        $serviceProvider = ServiceProvider::getInstance();
Severity: Minor
Found in admin/repoadmin.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $ID is not named in camelCase.
Open

    private function saveLinkToDatabase($pmServiceName, $project, $issue_id, $isMergeRequest)
    {
        global $ID;
        $currentRev = @filemtime(wikiFN($ID));
Severity: Minor
Found in syntax.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $db_helper is not named in camelCase.
Open

    private function saveLinkToDatabase($pmServiceName, $project, $issue_id, $isMergeRequest)
    {
        global $ID;
        $currentRev = @filemtime(wikiFN($ID));
Severity: Minor
Found in syntax.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $INPUT is not named in camelCase.
Open

    public function repoAdminToggle(Doku_Event $event, $param)
    {
        if ($event->data !== 'issuelinks_repo_admin_toggle') {
            return;
        }
Severity: Minor
Found in action/ajax.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $INPUT is not named in camelCase.
Open

    public function handleAjax(Doku_Event $event, $param)
    {
        if ($event->data !== 'plugin_issuelinks') {
            return;
        }
Severity: Minor
Found in action/ajax.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $INPUT is not named in camelCase.
Open

    public function handleAjax(Doku_Event $event, $param)
    {
        if ($event->data !== 'plugin_issuelinks') {
            return;
        }
Severity: Minor
Found in action/ajax.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $ID is not named in camelCase.
Open

    public function test_jiralink_moresyntax() {
        // arrange
        global $ID;
        $ID = 'testpage2';
        saveWikiText($ID,'page must exist for m_filetime','test summary');
Severity: Minor
Found in _test/handleIssueLinkSyntax.test.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $pagerev_issues is not named in camelCase.
Open

    public function test_jiralink_moresyntax() {
        // arrange
        global $ID;
        $ID = 'testpage2';
        saveWikiText($ID,'page must exist for m_filetime','test summary');
Severity: Minor
Found in _test/handleIssueLinkSyntax.test.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $INPUT is not named in camelCase.
Open

    public static function isOurWebhook()
    {
        global $INPUT;
        $userAgent = $INPUT->server->str('HTTP_USER_AGENT');
        return strpos($userAgent, self::WEBHOOK_UA) === 0;
Severity: Minor
Found in services/GitHub.service.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $INPUT is not named in camelCase.
Open

    public static function isOurWebhook()
    {
        global $INPUT;
        if ($INPUT->server->has('HTTP_X_GITLAB_TOKEN')) {
            return true;
Severity: Minor
Found in services/GitLab.service.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $INPUT is not named in camelCase.
Open

    public static function isOurWebhook()
    {
        global $INPUT;
        $userAgent = $INPUT->server->str('HTTP_USER_AGENT');
        return strpos($userAgent, 'Atlassian') === 0;
Severity: Minor
Found in services/Jira.service.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $issue_id is not named in camelCase.
Open

    public function removeOldLinks($serviceName, $projectKey, $issue_id, $isMergeRequest, $pages)
    {
        $activeLinks = [];

        foreach ($pages as $linkingPage) {
Severity: Minor
Found in helper/db.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

Severity
Category
Status
Source
Language