Sign upLogin

cosmocode/dokuwiki-plugin-issuelinks

View on GitHub
Star

Showing 899 of 899 total issues

The variable $issue_id is not named in camelCase.
Open

    public function savePageRevIssues($page, $rev, $serviceName, $project, $issue_id, $isMergeRequest, $type)
    {
        /** @var helper_plugin_issuelinks_util $util */
        $util = plugin_load('helper', 'issuelinks_util');
        if (!$util->isValidTimeStamp($rev)) {
Severity: Minor
Found in helper/db.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $rev_info is not named in camelCase.
Open

    public function savePageRevIssues($page, $rev, $serviceName, $project, $issue_id, $isMergeRequest, $type)
    {
        /** @var helper_plugin_issuelinks_util $util */
        $util = plugin_load('helper', 'issuelinks_util');
        if (!$util->isValidTimeStamp($rev)) {
Severity: Minor
Found in helper/db.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $page_id is not named in camelCase.
Open

    public function getDiffUrl($page_id, $revision = 0)
    {
        if (empty($revision)) {
            $currentRevision = filemtime(wikiFN($page_id));
            $url = wl(
Severity: Minor
Found in helper/util.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $rev_info is not named in camelCase.
Open

    public function savePageRevIssues($page, $rev, $serviceName, $project, $issue_id, $isMergeRequest, $type)
    {
        /** @var helper_plugin_issuelinks_util $util */
        $util = plugin_load('helper', 'issuelinks_util');
        if (!$util->isValidTimeStamp($rev)) {
Severity: Minor
Found in helper/db.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $issue_id is not named in camelCase.
Open

    public function savePageRevIssues($page, $rev, $serviceName, $project, $issue_id, $isMergeRequest, $type)
    {
        /** @var helper_plugin_issuelinks_util $util */
        $util = plugin_load('helper', 'issuelinks_util');
        if (!$util->isValidTimeStamp($rev)) {
Severity: Minor
Found in helper/db.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $issue_id is not named in camelCase.
Open

    public function savePageRevIssues($page, $rev, $serviceName, $project, $issue_id, $isMergeRequest, $type)
    {
        /** @var helper_plugin_issuelinks_util $util */
        $util = plugin_load('helper', 'issuelinks_util');
        if (!$util->isValidTimeStamp($rev)) {
Severity: Minor
Found in helper/db.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $rev_info is not named in camelCase.
Open

    public function savePageRevIssues($page, $rev, $serviceName, $project, $issue_id, $isMergeRequest, $type)
    {
        /** @var helper_plugin_issuelinks_util $util */
        $util = plugin_load('helper', 'issuelinks_util');
        if (!$util->isValidTimeStamp($rev)) {
Severity: Minor
Found in helper/db.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $rev_info is not named in camelCase.
Open

    public function savePageRevIssues($page, $rev, $serviceName, $project, $issue_id, $isMergeRequest, $type)
    {
        /** @var helper_plugin_issuelinks_util $util */
        $util = plugin_load('helper', 'issuelinks_util');
        if (!$util->isValidTimeStamp($rev)) {
Severity: Minor
Found in helper/db.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $MSG is not named in camelCase.
Open

    public function sendResponse($code, $msg)
    {
        header('Content-Type: application/json');
        if ((int)$code === 204) {
            http_status(200);
Severity: Minor
Found in helper/util.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The method test_plugininfo is not named in camelCase.
Open

    public function test_plugininfo()
    {
        $file = __DIR__ . '/../plugin.info.txt';
        $this->assertFileExists($file);
Severity: Minor
Found in _test/general.test.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method test_jiralink_oldrev is not named in camelCase.
Open

    public function test_jiralink_oldrev() {
        // arrange
        global $ID, $REV;
        $ID = 'testpage_oldnew';
        saveWikiText($ID,'{{jira>SPR-281}} {{jira>TW-7}}','test summary');
Severity: Minor
Found in _test/handleIssueLinkSyntax.test.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method test_plugin_conf is not named in camelCase.
Open

    public function test_plugin_conf()
    {
        $conf_file = __DIR__ . '/../conf/default.php';
        if (file_exists($conf_file)) {
            include($conf_file);
Severity: Minor
Found in _test/general.test.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method test_jiralink is not named in camelCase.
Open

    public function test_jiralink() {
        // arrange
        global $ID;
        $ID = 'testpage';
        saveWikiText('testpage','[[jira>SPR-281]] [[jira>TW-7]]','test summary');
Severity: Minor
Found in _test/handleIssueLinkSyntax.test.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method test_parseHTTPLinkHeaders is not named in camelCase.
Open

    public function test_parseHTTPLinkHeaders($linkHeader, $expected_links, $msg) {
        /** @var helper_plugin_issuelinks_util $helper*/
        $helper = plugin_load('helper', 'issuelinks_util');

        $actual_links = $helper->parseHTTPLinkHeaders($linkHeader);
Severity: Minor
Found in _test/util.test.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method parseHTTPLinkHeaders_testdata is not named in camelCase.
Open

    public static function parseHTTPLinkHeaders_testdata() {
        return array(
            array(
                '<https://api.github.com/repositories/48178744/commits?page=2>; rel="next", <https://api.github.com/repositories/48178744/commits?page=23>; rel="last"',
                array(
Severity: Minor
Found in _test/util.test.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method test_jiralink_moresyntax is not named in camelCase.
Open

    public function test_jiralink_moresyntax() {
        // arrange
        global $ID;
        $ID = 'testpage2';
        saveWikiText($ID,'page must exist for m_filetime','test summary');
Severity: Minor
Found in _test/handleIssueLinkSyntax.test.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

Call to undeclared method \general_plugin_issuelinks_test::assertArrayHasKey
Open

        $this->assertArrayHasKey('email', $info);
Severity: Critical
Found in _test/general.test.php by phan

Call to undeclared method \general_plugin_issuelinks_test::assertRegExp
Open

        $this->assertRegExp('/^https?:\/\//', $info['url']);
Severity: Critical
Found in _test/general.test.php by phan

Call to undeclared function \plugin_load()
Open

        $db = plugin_load('helper', 'issuelinks_db');
Severity: Critical
Found in _test/handleIssueLinkSyntax.test.php by phan

Call to undeclared method \linksyntax_plugin_issuelinks_test::assertEquals
Open

        $this->assertEquals(array(), $pagerev_issues);
Severity: Critical
Found in _test/handleIssueLinkSyntax.test.php by phan
Severity
Category
Status
Source
Language