Sign upLogin

countries/country_select

View on GitHub
Star
lib/country_select/country_select_helper.rb

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

ActionView::Helpers::FormOptionsHelper#country_select has 4 parameters
Invalid

      def country_select(object, method, options = {}, html_options = {})
Severity: Minor
Found in lib/country_select/country_select_helper.rb by reek

A Long Parameter List occurs when a method has a lot of parameters.

Example

Given

class Dummy
  def long_list(foo,bar,baz,fling,flung)
    puts foo,bar,baz,fling,flung
  end
end

Reek would report the following warning:

test.rb -- 1 warning:
  [2]:Dummy#long_list has 5 parameters (LongParameterList)

A common solution to this problem would be the introduction of parameter objects.

Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
Wontfix

        def initialize(object_name, method_name, template_object, options, html_options)
Severity: Minor
Found in lib/country_select/country_select_helper.rb - About 35 mins to fix

    ActionView::Helpers::FormBuilder assumes too much for instance variable '@default_options'
    Invalid

        class FormBuilder
    Severity: Minor
    Found in lib/country_select/country_select_helper.rb by reek

    Classes should not assume that instance variables are set or present outside of the current class definition.

    Good:

    class Foo
  def initialize
    @bar = :foo
  end

  def foo?
    @bar == :foo
  end
end

    Good as well:

    class Foo
  def foo?
    bar == :foo
  end

  def bar
    @bar ||= :foo
  end
end

    Bad:

    class Foo
  def go_foo!
    @bar = :foo
  end

  def foo?
    @bar == :foo
  end
end

    Example

    Running Reek on:

    class Dummy
  def test
    @ivar
  end
end

    would report:

    [1]:InstanceVariableAssumption: Dummy assumes too much for instance variable @ivar

    Note that this example would trigger this smell warning as well:

    class Parent
  def initialize(omg)
    @omg = omg
  end
end

class Child < Parent
  def foo
    @omg
  end
end

    The way to address the smell warning is that you should create an attr_reader to use @omg in the subclass and not access @omg directly like this:

    class Parent
  attr_reader :omg

  def initialize(omg)
    @omg = omg
  end
end

class Child < Parent
  def foo
    omg
  end
end

    Directly accessing instance variables is considered a smell because it breaks encapsulation and makes it harder to reason about code.

    If you don't want to expose those methods as public API just make them private like this:

    class Parent
  def initialize(omg)
    @omg = omg
  end

  private
  attr_reader :omg
end

class Child < Parent
  def foo
    omg
  end
end

    Current Support in Reek

    An instance variable must:

    • be set in the constructor
    • or be accessed through a method with lazy initialization / memoization.

    If not, Instance Variable Assumption will be reported.

    ActionView::Helpers::FormBuilder assumes too much for instance variable '@template'
    Invalid

        class FormBuilder
    Severity: Minor
    Found in lib/country_select/country_select_helper.rb by reek

    Classes should not assume that instance variables are set or present outside of the current class definition.

    Good:

    class Foo
  def initialize
    @bar = :foo
  end

  def foo?
    @bar == :foo
  end
end

    Good as well:

    class Foo
  def foo?
    bar == :foo
  end

  def bar
    @bar ||= :foo
  end
end

    Bad:

    class Foo
  def go_foo!
    @bar = :foo
  end

  def foo?
    @bar == :foo
  end
end

    Example

    Running Reek on:

    class Dummy
  def test
    @ivar
  end
end

    would report:

    [1]:InstanceVariableAssumption: Dummy assumes too much for instance variable @ivar

    Note that this example would trigger this smell warning as well:

    class Parent
  def initialize(omg)
    @omg = omg
  end
end

class Child < Parent
  def foo
    @omg
  end
end

    The way to address the smell warning is that you should create an attr_reader to use @omg in the subclass and not access @omg directly like this:

    class Parent
  attr_reader :omg

  def initialize(omg)
    @omg = omg
  end
end

class Child < Parent
  def foo
    omg
  end
end

    Directly accessing instance variables is considered a smell because it breaks encapsulation and makes it harder to reason about code.

    If you don't want to expose those methods as public API just make them private like this:

    class Parent
  def initialize(omg)
    @omg = omg
  end

  private
  attr_reader :omg
end

class Child < Parent
  def foo
    omg
  end
end

    Current Support in Reek

    An instance variable must:

    • be set in the constructor
    • or be accessed through a method with lazy initialization / memoization.

    If not, Instance Variable Assumption will be reported.

    ActionView::Helpers::Tags::CountrySelect assumes too much for instance variable '@options'
    Invalid

          class CountrySelect < Base
    Severity: Minor
    Found in lib/country_select/country_select_helper.rb by reek

    Classes should not assume that instance variables are set or present outside of the current class definition.

    Good:

    class Foo
  def initialize
    @bar = :foo
  end

  def foo?
    @bar == :foo
  end
end

    Good as well:

    class Foo
  def foo?
    bar == :foo
  end

  def bar
    @bar ||= :foo
  end
end

    Bad:

    class Foo
  def go_foo!
    @bar = :foo
  end

  def foo?
    @bar == :foo
  end
end

    Example

    Running Reek on:

    class Dummy
  def test
    @ivar
  end
end

    would report:

    [1]:InstanceVariableAssumption: Dummy assumes too much for instance variable @ivar

    Note that this example would trigger this smell warning as well:

    class Parent
  def initialize(omg)
    @omg = omg
  end
end

class Child < Parent
  def foo
    @omg
  end
end

    The way to address the smell warning is that you should create an attr_reader to use @omg in the subclass and not access @omg directly like this:

    class Parent
  attr_reader :omg

  def initialize(omg)
    @omg = omg
  end
end

class Child < Parent
  def foo
    omg
  end
end

    Directly accessing instance variables is considered a smell because it breaks encapsulation and makes it harder to reason about code.

    If you don't want to expose those methods as public API just make them private like this:

    class Parent
  def initialize(omg)
    @omg = omg
  end

  private
  attr_reader :omg
end

class Child < Parent
  def foo
    omg
  end
end

    Current Support in Reek

    An instance variable must:

    • be set in the constructor
    • or be accessed through a method with lazy initialization / memoization.

    If not, Instance Variable Assumption will be reported.

    ActionView::Helpers::FormBuilder assumes too much for instance variable '@object_name'
    Invalid

        class FormBuilder
    Severity: Minor
    Found in lib/country_select/country_select_helper.rb by reek

    Classes should not assume that instance variables are set or present outside of the current class definition.

    Good:

    class Foo
  def initialize
    @bar = :foo
  end

  def foo?
    @bar == :foo
  end
end

    Good as well:

    class Foo
  def foo?
    bar == :foo
  end

  def bar
    @bar ||= :foo
  end
end

    Bad:

    class Foo
  def go_foo!
    @bar = :foo
  end

  def foo?
    @bar == :foo
  end
end

    Example

    Running Reek on:

    class Dummy
  def test
    @ivar
  end
end

    would report:

    [1]:InstanceVariableAssumption: Dummy assumes too much for instance variable @ivar

    Note that this example would trigger this smell warning as well:

    class Parent
  def initialize(omg)
    @omg = omg
  end
end

class Child < Parent
  def foo
    @omg
  end
end

    The way to address the smell warning is that you should create an attr_reader to use @omg in the subclass and not access @omg directly like this:

    class Parent
  attr_reader :omg

  def initialize(omg)
    @omg = omg
  end
end

class Child < Parent
  def foo
    omg
  end
end

    Directly accessing instance variables is considered a smell because it breaks encapsulation and makes it harder to reason about code.

    If you don't want to expose those methods as public API just make them private like this:

    class Parent
  def initialize(omg)
    @omg = omg
  end

  private
  attr_reader :omg
end

class Child < Parent
  def foo
    omg
  end
end

    Current Support in Reek

    An instance variable must:

    • be set in the constructor
    • or be accessed through a method with lazy initialization / memoization.

    If not, Instance Variable Assumption will be reported.

    There are no issues that match your filters.

    Category
    Status