Sign upLogin

creof/doctrine2-spatial

View on GitHub
Star

Showing 447 of 447 total issues

Opening brace of a class must be on the line after the definition
Open

class STEquals extends AbstractSpatialDQLFunction {
Severity: Minor
Found in lib/CrEOF/Spatial/ORM/Query/AST/Functions/MySql/STEquals.php by phpcodesniffer

The closing brace for the class must go on the next line after the body
Open

}
Severity: Minor
Found in lib/CrEOF/Spatial/ORM/Query/AST/Functions/MySql/STDisjoint.php by phpcodesniffer

The closing brace for the class must go on the next line after the body
Open

}
Severity: Minor
Found in lib/CrEOF/Spatial/ORM/Query/AST/Functions/PostgreSql/STScale.php by phpcodesniffer

There must be one blank line after the last USE statement; 0 found;
Open

use CrEOF\Spatial\PHP\Types\Geometry\Polygon;
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/PHP/Types/Geometry/PolygonTest.php by phpcodesniffer

The closing brace for the class must go on the next line after the body
Open

}
Severity: Minor
Found in lib/CrEOF/Spatial/ORM/Query/AST/Functions/MySql/Distance.php by phpcodesniffer

Opening brace of a class must be on the line after the definition
Open

class STContains extends AbstractSpatialDQLFunction {
Severity: Minor
Found in lib/CrEOF/Spatial/ORM/Query/AST/Functions/MySql/STContains.php by phpcodesniffer

The closing brace for the class must go on the next line after the body
Open

}
Severity: Minor
Found in lib/CrEOF/Spatial/ORM/Query/AST/Functions/MySql/STCrosses.php by phpcodesniffer

Opening brace of a class must be on the line after the definition
Open

class STDisjoint extends AbstractSpatialDQLFunction {
Severity: Minor
Found in lib/CrEOF/Spatial/ORM/Query/AST/Functions/MySql/STDisjoint.php by phpcodesniffer

There must be one blank line after the last USE statement; 0 found;
Open

use CrEOF\Spatial\PHP\Types\Geometry\Polygon;
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/PHP/Types/Geometry/MultiPolygonTest.php by phpcodesniffer

Opening brace of a class must be on the line after the definition
Open

class STDistance extends AbstractSpatialDQLFunction {
Severity: Minor
Found in lib/CrEOF/Spatial/ORM/Query/AST/Functions/MySql/STDistance.php by phpcodesniffer

Function setUpTypes has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    protected function setUpTypes()
    {
        foreach (array_keys($this->usedTypes) as $typeName) {
            if (! isset(static::$addedTypes[$typeName]) && ! Type::hasType($typeName)) {
                Type::addType($typeName, static::$types[$typeName]);
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/OrmTestCase.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The closing brace for the class must go on the next line after the body
Open

}
Severity: Minor
Found in lib/CrEOF/Spatial/ORM/Query/AST/Functions/MySql/STContains.php by phpcodesniffer

Opening brace of a class must be on the line after the definition
Open

class STTouches extends AbstractSpatialDQLFunction {
Severity: Minor
Found in lib/CrEOF/Spatial/ORM/Query/AST/Functions/MySql/STTouches.php by phpcodesniffer

Opening brace of a class must be on the line after the definition
Open

class STCrosses extends AbstractSpatialDQLFunction {
Severity: Minor
Found in lib/CrEOF/Spatial/ORM/Query/AST/Functions/MySql/STCrosses.php by phpcodesniffer

Opening brace of a class must be on the line after the definition
Open

class STDistanceSphere extends AbstractSpatialDQLFunction {
Severity: Minor
Found in lib/CrEOF/Spatial/ORM/Query/AST/Functions/MySql/STDistanceSphere.php by phpcodesniffer

The closing brace for the class must go on the next line after the body
Open

}
Severity: Minor
Found in lib/CrEOF/Spatial/ORM/Query/AST/Functions/MySql/STWithin.php by phpcodesniffer

The closing brace for the class must go on the next line after the body
Open

}
Severity: Minor
Found in lib/CrEOF/Spatial/ORM/Query/AST/Functions/MySql/STOverlaps.php by phpcodesniffer

The closing brace for the class must go on the next line after the body
Open

}
Severity: Minor
Found in lib/CrEOF/Spatial/ORM/Query/AST/Functions/MySql/STTouches.php by phpcodesniffer

Similar blocks of code found in 5 locations. Consider refactoring.
Open

        $polygon =  new Polygon(
            array (
                new LineString(
                    array (
                        new Point(0, 0),
Severity: Major
Found in tests/CrEOF/Spatial/Tests/PHP/Types/Geometry/MultiPolygonTest.php and 4 other locations - About 30 mins to fix
tests/CrEOF/Spatial/Tests/PHP/Types/Geometry/MultiPolygonTest.php on lines 211..223
tests/CrEOF/Spatial/Tests/PHP/Types/Geometry/MultiPolygonTest.php on lines 224..236
tests/CrEOF/Spatial/Tests/PHP/Types/Geometry/MultiPolygonTest.php on lines 244..256
tests/CrEOF/Spatial/Tests/PHP/Types/Geometry/MultiPolygonTest.php on lines 257..269

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

        $polygon1 = new Polygon(
            array(
                new LineString(
                    array(
                        new Point(0, 0),
Severity: Major
Found in tests/CrEOF/Spatial/Tests/PHP/Types/Geometry/MultiPolygonTest.php and 4 other locations - About 30 mins to fix
tests/CrEOF/Spatial/Tests/PHP/Types/Geometry/MultiPolygonTest.php on lines 175..187
tests/CrEOF/Spatial/Tests/PHP/Types/Geometry/MultiPolygonTest.php on lines 211..223
tests/CrEOF/Spatial/Tests/PHP/Types/Geometry/MultiPolygonTest.php on lines 224..236
tests/CrEOF/Spatial/Tests/PHP/Types/Geometry/MultiPolygonTest.php on lines 257..269

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language