Sign upLogin

creof/doctrine2-spatial

View on GitHub
Star
tests/CrEOF/Spatial/Tests/DBAL/Types/GeographyTypeTest.php

Summary

Maintainability
C
1 day
Test Coverage

Missing class import via use statement (line '140', column '23').
Open

            throw new \PHPUnit_Framework_Error(
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/DBAL/Types/GeographyTypeTest.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function testPolygonGeography()
    {
        $entity = new GeographyEntity();

        $rings = array(
Severity: Major
Found in tests/CrEOF/Spatial/Tests/DBAL/Types/GeographyTypeTest.php and 1 other location - About 5 hrs to fix
tests/CrEOF/Spatial/Tests/DBAL/Types/GeometryTypeTest.php on lines 150..175

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 192.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function testLineStringGeography()
    {
        $entity = new GeographyEntity();

        $entity->setGeography(new LineString(
Severity: Major
Found in tests/CrEOF/Spatial/Tests/DBAL/Types/GeographyTypeTest.php and 1 other location - About 2 hrs to fix
tests/CrEOF/Spatial/Tests/DBAL/Types/GeometryTypeTest.php on lines 128..148

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 135.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function testPointGeography()
    {
        $entity = new GeographyEntity();

        $entity->setGeography(new Point(1, 1));
Severity: Major
Found in tests/CrEOF/Spatial/Tests/DBAL/Types/GeographyTypeTest.php and 1 other location - About 1 hr to fix
tests/CrEOF/Spatial/Tests/DBAL/Types/GeometryTypeTest.php on lines 67..82

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 111.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid variables with short names like $id. Configured minimum length is 3.
Open

        $id = $entity->getId();
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/DBAL/Types/GeographyTypeTest.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $id. Configured minimum length is 3.
Open

        $id = $entity->getId();
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/DBAL/Types/GeographyTypeTest.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $id. Configured minimum length is 3.
Open

        $id = $entity->getId();
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/DBAL/Types/GeographyTypeTest.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $id. Configured minimum length is 3.
Open

        $id = $entity->getId();
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/DBAL/Types/GeographyTypeTest.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Multi-line function call not indented correctly; expected 8 spaces but found 12
Open

            ))
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/DBAL/Types/GeographyTypeTest.php by phpcodesniffer

Closing parenthesis of a multi-line function call must be on a line by itself
Open

            ))
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/DBAL/Types/GeographyTypeTest.php by phpcodesniffer

Expected 0 spaces before closing bracket; newline found
Open

        $entity->setGeography(new LineString(
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/DBAL/Types/GeographyTypeTest.php by phpcodesniffer

There are no issues that match your filters.

Category
Status