creof/doctrine2-spatial

View on GitHub
tests/CrEOF/Spatial/Tests/ORM/Query/GeometryWalkerTest.php

Summary

Maintainability
F
5 days
Test Coverage

Method testGeometryWalkerText has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testGeometryWalkerText()
    {
        $lineString1 = new LineString(array(
            new Point(0, 0),
            new Point(2, 2),
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/ORM/Query/GeometryWalkerTest.php - About 1 hr to fix

Method testGeometryWalkerBinary has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testGeometryWalkerBinary()
    {
        $lineString1 = new LineString(array(
            new Point(0, 0),
            new Point(2, 2),
Severity: Minor
Found in tests/CrEOF/Spatial/Tests/ORM/Query/GeometryWalkerTest.php - About 1 hr to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function testGeometryWalkerBinary()
    {
        $lineString1 = new LineString(array(
            new Point(0, 0),
            new Point(2, 2),
Severity: Major
Found in tests/CrEOF/Spatial/Tests/ORM/Query/GeometryWalkerTest.php and 1 other location - About 2 days to fix
tests/CrEOF/Spatial/Tests/ORM/Query/GeometryWalkerTest.php on lines 108..160

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 476.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function testGeometryWalkerText()
    {
        $lineString1 = new LineString(array(
            new Point(0, 0),
            new Point(2, 2),
Severity: Major
Found in tests/CrEOF/Spatial/Tests/ORM/Query/GeometryWalkerTest.php and 1 other location - About 2 days to fix
tests/CrEOF/Spatial/Tests/ORM/Query/GeometryWalkerTest.php on lines 51..103

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 476.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Line exceeds 120 characters; contains 139 characters
Open

        $queryString = sprintf('SELECT %s(%s(l.lineString)) FROM CrEOF\Spatial\Tests\Fixtures\LineStringEntity l', $asBinary, $startPoint);

Line exceeds 120 characters; contains 137 characters
Open

        $queryString = sprintf('SELECT %s(%s(l.lineString)) FROM CrEOF\Spatial\Tests\Fixtures\LineStringEntity l', $asText, $startPoint);

Line exceeds 120 characters; contains 135 characters
Open

        $queryString = sprintf('SELECT %s(%s(l.lineString)) FROM CrEOF\Spatial\Tests\Fixtures\LineStringEntity l', $asText, $envelope);

Line exceeds 120 characters; contains 137 characters
Open

        $queryString = sprintf('SELECT %s(%s(l.lineString)) FROM CrEOF\Spatial\Tests\Fixtures\LineStringEntity l', $asBinary, $envelope);

There are no issues that match your filters.

Category
Status