Sign upLogin

csirtgadgets/silver-meme

View on GitHub
Star
csirtg_indicator/utils/__init__.py

Summary

Maintainability
A
1 hr
Test Coverage

Function resolve_itype has a Cognitive Complexity of 12 (exceeds 10 allowed). Consider refactoring.
Open

def resolve_itype(indicator, test_broken=False):
    itype = False
    if test_broken and is_url_broken(indicator):
        itype = 'broken_url'
Severity: Minor
Found in csirtg_indicator/utils/__init__.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return False
Severity: Major
Found in csirtg_indicator/utils/__init__.py - About 30 mins to fix

    There are no issues that match your filters.

    Category
    Status