cubesystems/releaf

View on GitHub

Showing 95 of 95 total issues

Function RemoteValidator has 259 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var RemoteValidator = function( form )
{
    // self
    var v = this;
    var body = jQuery('body');
Severity: Major
Found in releaf-core/app/assets/javascripts/releaf/include/remote_validator.js - About 1 day to fix

    Function UrlBuilder has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
    Open

    function UrlBuilder( params )
    {
        if( params === undefined )
        {
            params = {};
    Severity: Minor
    Found in releaf-core/app/assets/javascripts/releaf/include/url_builder.js - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function add has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
    Open

    UrlBuilder.prototype.add = function( params, value )
    {
        if( params instanceof Array )
        {
            for( var i = 0; i < params.length; i++ )
    Severity: Minor
    Found in releaf-core/app/assets/javascripts/releaf/include/url_builder.js - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Class TableBuilder has 37 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class Releaf::Builders::TableBuilder
      include Releaf::Builders::Base
      include Releaf::Builders::Toolbox
      attr_accessor :collection, :options, :template, :resource_class
    
    
    Severity: Minor
    Found in releaf-core/app/builders/releaf/builders/table_builder.rb - About 4 hrs to fix

      Class LayoutBuilder has 31 methods (exceeds 20 allowed). Consider refactoring.
      Open

        class LayoutBuilder
          include Releaf::Builders::Base
          include Releaf::Builders::Template
      
          def output(&block)
      Severity: Minor
      Found in releaf-core/app/builders/releaf/builders/page/layout_builder.rb - About 3 hrs to fix

        File remote_validator.js has 316 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        var RemoteValidator = function( form )
        {
            // self
            var v = this;
            var body = jQuery('body');
        Severity: Minor
        Found in releaf-core/app/assets/javascripts/releaf/include/remote_validator.js - About 3 hrs to fix

          Class Settings has 29 methods (exceeds 20 allowed). Consider refactoring.
          Open

          class Releaf::Settings < ActiveRecord::Base
          
            self.table_name = table_name_prefix + "settings"
          
            class SettingNotFound < RuntimeError; end
          Severity: Minor
          Found in releaf-core/lib/releaf/settings.rb - About 3 hrs to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    block.find('.collection li').bind('nodeitemexpand', function( e )
                    {
                        e.stopPropagation();
            
                        var item = jQuery(e.target);
            releaf-content/app/assets/javascripts/controllers/releaf/content/nodes.js on lines 29..37

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 96.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    block.find('.collection li').bind('nodeitemcollapse', function( e )
                    {
                        e.stopPropagation();
            
                        var item = jQuery(e.target);
            releaf-content/app/assets/javascripts/controllers/releaf/content/nodes.js on lines 39..47

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 96.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Class ActionController has 26 methods (exceeds 20 allowed). Consider refactoring.
            Open

            class Releaf::ActionController < ActionController::Base
              # must be first other in stange way non-text env will
              # have CSRF on richtext attachment upload
              protect_from_forgery
            
            
            Severity: Minor
            Found in releaf-core/app/controllers/releaf/action_controller.rb - About 3 hrs to fix

              Function 'UrlBuilder' has a complexity of 17.
              Open

              function UrlBuilder( params )

              Limit Cyclomatic Complexity (complexity)

              Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

              function a(x) {
                  if (true) {
                      return x; // 1st path
                  } else if (false) {
                      return x+1; // 2nd path
                  } else {
                      return 4; // 3rd path
                  }
              }

              Rule Details

              This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

              Examples of incorrect code for a maximum of 2:

              /*eslint complexity: ["error", 2]*/
              
              function a(x) {
                  if (true) {
                      return x;
                  } else if (false) {
                      return x+1;
                  } else {
                      return 4; // 3rd path
                  }
              }

              Examples of correct code for a maximum of 2:

              /*eslint complexity: ["error", 2]*/
              
              function a(x) {
                  if (true) {
                      return x;
                  } else {
                      return 4;
                  }
              }

              Options

              Optionally, you may specify a max object property:

              "complexity": ["error", 2]

              is equivalent to

              "complexity": ["error", { "max": 2 }]

              Deprecated: the object property maximum is deprecated. Please use the property max instead.

              When Not To Use It

              If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

              Further Reading

              Related Rules

              • [max-depth](max-depth.md)
              • [max-len](max-len.md)
              • [max-nested-callbacks](max-nested-callbacks.md)
              • [max-params](max-params.md)
              • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

              Function UrlBuilder has 69 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function UrlBuilder( params )
              {
                  if( params === undefined )
                  {
                      params = {};
              Severity: Major
              Found in releaf-core/app/assets/javascripts/releaf/include/url_builder.js - About 2 hrs to fix

                Class TranslationsStore has 24 methods (exceeds 20 allowed). Consider refactoring.
                Open

                class Releaf::I18nDatabase::TranslationsStore
                  include Releaf::InstanceCache
                  attr_accessor :updated_at, :missing_keys
                
                  def initialize

                  Function has a complexity of 14.
                  Open

                  UrlBuilder.prototype.add = function( params, value )

                  Limit Cyclomatic Complexity (complexity)

                  Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

                  function a(x) {
                      if (true) {
                          return x; // 1st path
                      } else if (false) {
                          return x+1; // 2nd path
                      } else {
                          return 4; // 3rd path
                      }
                  }

                  Rule Details

                  This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

                  Examples of incorrect code for a maximum of 2:

                  /*eslint complexity: ["error", 2]*/
                  
                  function a(x) {
                      if (true) {
                          return x;
                      } else if (false) {
                          return x+1;
                      } else {
                          return 4; // 3rd path
                      }
                  }

                  Examples of correct code for a maximum of 2:

                  /*eslint complexity: ["error", 2]*/
                  
                  function a(x) {
                      if (true) {
                          return x;
                      } else {
                          return 4;
                      }
                  }

                  Options

                  Optionally, you may specify a max object property:

                  "complexity": ["error", 2]

                  is equivalent to

                  "complexity": ["error", { "max": 2 }]

                  Deprecated: the object property maximum is deprecated. Please use the property max instead.

                  When Not To Use It

                  If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

                  Further Reading

                  Related Rules

                  • [max-depth](max-depth.md)
                  • [max-len](max-len.md)
                  • [max-nested-callbacks](max-nested-callbacks.md)
                  • [max-params](max-params.md)
                  • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

                  Function has too many statements (37). Maximum allowed is 30.
                  Open

                      v.form.on( 'validation:error', function( event, v, event_params )

                  enforce a maximum number of statements allowed in function blocks (max-statements)

                  The max-statements rule allows you to specify the maximum number of statements allowed in a function.

                  function foo() {
                    var bar = 1; // one statement
                    var baz = 2; // two statements
                    var qux = 3; // three statements
                  }

                  Rule Details

                  This rule enforces a maximum number of statements allowed in function blocks.

                  Options

                  This rule has a number or object option:

                  • "max" (default 10) enforces a maximum number of statements allows in function blocks

                  Deprecated: The object property maximum is deprecated; please use the object property max instead.

                  This rule has an object option:

                  • "ignoreTopLevelFunctions": true ignores top-level functions

                  max

                  Examples of incorrect code for this rule with the default { "max": 10 } option:

                  /*eslint max-statements: ["error", 10]*/
                  /*eslint-env es6*/
                  
                  function foo() {
                    var foo1 = 1;
                    var foo2 = 2;
                    var foo3 = 3;
                    var foo4 = 4;
                    var foo5 = 5;
                    var foo6 = 6;
                    var foo7 = 7;
                    var foo8 = 8;
                    var foo9 = 9;
                    var foo10 = 10;
                  
                    var foo11 = 11; // Too many.
                  }
                  
                  let foo = () => {
                    var foo1 = 1;
                    var foo2 = 2;
                    var foo3 = 3;
                    var foo4 = 4;
                    var foo5 = 5;
                    var foo6 = 6;
                    var foo7 = 7;
                    var foo8 = 8;
                    var foo9 = 9;
                    var foo10 = 10;
                  
                    var foo11 = 11; // Too many.
                  };

                  Examples of correct code for this rule with the default { "max": 10 } option:

                  /*eslint max-statements: ["error", 10]*/
                  /*eslint-env es6*/
                  
                  function foo() {
                    var foo1 = 1;
                    var foo2 = 2;
                    var foo3 = 3;
                    var foo4 = 4;
                    var foo5 = 5;
                    var foo6 = 6;
                    var foo7 = 7;
                    var foo8 = 8;
                    var foo9 = 9;
                    var foo10 = 10;
                    return function () {
                  
                      // The number of statements in the inner function does not count toward the
                      // statement maximum.
                  
                      return 42;
                    };
                  }
                  
                  let foo = () => {
                    var foo1 = 1;
                    var foo2 = 2;
                    var foo3 = 3;
                    var foo4 = 4;
                    var foo5 = 5;
                    var foo6 = 6;
                    var foo7 = 7;
                    var foo8 = 8;
                    var foo9 = 9;
                    var foo10 = 10;
                    return function () {
                  
                      // The number of statements in the inner function does not count toward the
                      // statement maximum.
                  
                      return 42;
                    };
                  }

                  ignoreTopLevelFunctions

                  Examples of additional correct code for this rule with the { "max": 10 }, { "ignoreTopLevelFunctions": true } options:

                  /*eslint max-statements: ["error", 10, { "ignoreTopLevelFunctions": true }]*/
                  
                  function foo() {
                    var foo1 = 1;
                    var foo2 = 2;
                    var foo3 = 3;
                    var foo4 = 4;
                    var foo5 = 5;
                    var foo6 = 6;
                    var foo7 = 7;
                    var foo8 = 8;
                    var foo9 = 9;
                    var foo10 = 10;
                    var foo11 = 11;
                  }

                  Related Rules

                  • [complexity](complexity.md)
                  • [max-depth](max-depth.md)
                  • [max-len](max-len.md)
                  • [max-nested-callbacks](max-nested-callbacks.md)
                  • [max-params](max-params.md) Source: http://eslint.org/docs/rules/

                  Function 'UrlBuilder' has too many statements (37). Maximum allowed is 30.
                  Open

                  function UrlBuilder( params )

                  enforce a maximum number of statements allowed in function blocks (max-statements)

                  The max-statements rule allows you to specify the maximum number of statements allowed in a function.

                  function foo() {
                    var bar = 1; // one statement
                    var baz = 2; // two statements
                    var qux = 3; // three statements
                  }

                  Rule Details

                  This rule enforces a maximum number of statements allowed in function blocks.

                  Options

                  This rule has a number or object option:

                  • "max" (default 10) enforces a maximum number of statements allows in function blocks

                  Deprecated: The object property maximum is deprecated; please use the object property max instead.

                  This rule has an object option:

                  • "ignoreTopLevelFunctions": true ignores top-level functions

                  max

                  Examples of incorrect code for this rule with the default { "max": 10 } option:

                  /*eslint max-statements: ["error", 10]*/
                  /*eslint-env es6*/
                  
                  function foo() {
                    var foo1 = 1;
                    var foo2 = 2;
                    var foo3 = 3;
                    var foo4 = 4;
                    var foo5 = 5;
                    var foo6 = 6;
                    var foo7 = 7;
                    var foo8 = 8;
                    var foo9 = 9;
                    var foo10 = 10;
                  
                    var foo11 = 11; // Too many.
                  }
                  
                  let foo = () => {
                    var foo1 = 1;
                    var foo2 = 2;
                    var foo3 = 3;
                    var foo4 = 4;
                    var foo5 = 5;
                    var foo6 = 6;
                    var foo7 = 7;
                    var foo8 = 8;
                    var foo9 = 9;
                    var foo10 = 10;
                  
                    var foo11 = 11; // Too many.
                  };

                  Examples of correct code for this rule with the default { "max": 10 } option:

                  /*eslint max-statements: ["error", 10]*/
                  /*eslint-env es6*/
                  
                  function foo() {
                    var foo1 = 1;
                    var foo2 = 2;
                    var foo3 = 3;
                    var foo4 = 4;
                    var foo5 = 5;
                    var foo6 = 6;
                    var foo7 = 7;
                    var foo8 = 8;
                    var foo9 = 9;
                    var foo10 = 10;
                    return function () {
                  
                      // The number of statements in the inner function does not count toward the
                      // statement maximum.
                  
                      return 42;
                    };
                  }
                  
                  let foo = () => {
                    var foo1 = 1;
                    var foo2 = 2;
                    var foo3 = 3;
                    var foo4 = 4;
                    var foo5 = 5;
                    var foo6 = 6;
                    var foo7 = 7;
                    var foo8 = 8;
                    var foo9 = 9;
                    var foo10 = 10;
                    return function () {
                  
                      // The number of statements in the inner function does not count toward the
                      // statement maximum.
                  
                      return 42;
                    };
                  }

                  ignoreTopLevelFunctions

                  Examples of additional correct code for this rule with the { "max": 10 }, { "ignoreTopLevelFunctions": true } options:

                  /*eslint max-statements: ["error", 10, { "ignoreTopLevelFunctions": true }]*/
                  
                  function foo() {
                    var foo1 = 1;
                    var foo2 = 2;
                    var foo3 = 3;
                    var foo4 = 4;
                    var foo5 = 5;
                    var foo6 = 6;
                    var foo7 = 7;
                    var foo8 = 8;
                    var foo9 = 9;
                    var foo10 = 10;
                    var foo11 = 11;
                  }

                  Related Rules

                  • [complexity](complexity.md)
                  • [max-depth](max-depth.md)
                  • [max-len](max-len.md)
                  • [max-nested-callbacks](max-nested-callbacks.md)
                  • [max-params](max-params.md) Source: http://eslint.org/docs/rules/

                  Function has a complexity of 12.
                  Open

                      v.form.on( 'validation:error', function( event, v, event_params )

                  Limit Cyclomatic Complexity (complexity)

                  Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

                  function a(x) {
                      if (true) {
                          return x; // 1st path
                      } else if (false) {
                          return x+1; // 2nd path
                      } else {
                          return 4; // 3rd path
                      }
                  }

                  Rule Details

                  This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

                  Examples of incorrect code for a maximum of 2:

                  /*eslint complexity: ["error", 2]*/
                  
                  function a(x) {
                      if (true) {
                          return x;
                      } else if (false) {
                          return x+1;
                      } else {
                          return 4; // 3rd path
                      }
                  }

                  Examples of correct code for a maximum of 2:

                  /*eslint complexity: ["error", 2]*/
                  
                  function a(x) {
                      if (true) {
                          return x;
                      } else {
                          return 4;
                      }
                  }

                  Options

                  Optionally, you may specify a max object property:

                  "complexity": ["error", 2]

                  is equivalent to

                  "complexity": ["error", { "max": 2 }]

                  Deprecated: the object property maximum is deprecated. Please use the property max instead.

                  When Not To Use It

                  If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

                  Further Reading

                  Related Rules

                  • [max-depth](max-depth.md)
                  • [max-len](max-len.md)
                  • [max-nested-callbacks](max-nested-callbacks.md)
                  • [max-params](max-params.md)
                  • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

                  Class IndexBuilder has 22 methods (exceeds 20 allowed). Consider refactoring.
                  Open

                  class Releaf::Builders::IndexBuilder
                    include Releaf::Builders::View
                    include Releaf::Builders::Collection
                  
                    def header_extras
                  Severity: Minor
                  Found in releaf-core/app/builders/releaf/builders/index_builder.rb - About 2 hrs to fix

                    Function has a complexity of 11.
                    Open

                                block.click( function( event, event_params )

                    Limit Cyclomatic Complexity (complexity)

                    Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

                    function a(x) {
                        if (true) {
                            return x; // 1st path
                        } else if (false) {
                            return x+1; // 2nd path
                        } else {
                            return 4; // 3rd path
                        }
                    }

                    Rule Details

                    This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

                    Examples of incorrect code for a maximum of 2:

                    /*eslint complexity: ["error", 2]*/
                    
                    function a(x) {
                        if (true) {
                            return x;
                        } else if (false) {
                            return x+1;
                        } else {
                            return 4; // 3rd path
                        }
                    }

                    Examples of correct code for a maximum of 2:

                    /*eslint complexity: ["error", 2]*/
                    
                    function a(x) {
                        if (true) {
                            return x;
                        } else {
                            return 4;
                        }
                    }

                    Options

                    Optionally, you may specify a max object property:

                    "complexity": ["error", 2]

                    is equivalent to

                    "complexity": ["error", { "max": 2 }]

                    Deprecated: the object property maximum is deprecated. Please use the property max instead.

                    When Not To Use It

                    If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

                    Further Reading

                    Related Rules

                    • [max-depth](max-depth.md)
                    • [max-len](max-len.md)
                    • [max-nested-callbacks](max-nested-callbacks.md)
                    • [max-params](max-params.md)
                    • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

                    Function has a complexity of 10.
                    Open

                        body.on( 'richtextinit', 'textarea.richtext', function( event, extra_config )

                    Limit Cyclomatic Complexity (complexity)

                    Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

                    function a(x) {
                        if (true) {
                            return x; // 1st path
                        } else if (false) {
                            return x+1; // 2nd path
                        } else {
                            return 4; // 3rd path
                        }
                    }

                    Rule Details

                    This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

                    Examples of incorrect code for a maximum of 2:

                    /*eslint complexity: ["error", 2]*/
                    
                    function a(x) {
                        if (true) {
                            return x;
                        } else if (false) {
                            return x+1;
                        } else {
                            return 4; // 3rd path
                        }
                    }

                    Examples of correct code for a maximum of 2:

                    /*eslint complexity: ["error", 2]*/
                    
                    function a(x) {
                        if (true) {
                            return x;
                        } else {
                            return 4;
                        }
                    }

                    Options

                    Optionally, you may specify a max object property:

                    "complexity": ["error", 2]

                    is equivalent to

                    "complexity": ["error", { "max": 2 }]

                    Deprecated: the object property maximum is deprecated. Please use the property max instead.

                    When Not To Use It

                    If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

                    Further Reading

                    Related Rules

                    • [max-depth](max-depth.md)
                    • [max-len](max-len.md)
                    • [max-nested-callbacks](max-nested-callbacks.md)
                    • [max-params](max-params.md)
                    • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/
                    Severity
                    Category
                    Status
                    Source
                    Language