cubesystems/releaf

View on GitHub
lib/releaf/rspec/features_matchers.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method has_error? has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    def has_error?(error_message, options = {})
      error_found = false
      if options[:field]
        first('.field.has-error', minimum: 1) # wait for any errors to come from validation
        all(".field.has-error").each do |field_container|
Severity: Minor
Found in lib/releaf/rspec/features_matchers.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Cyclomatic complexity for has_error? is too high. [8/6]
Open

    def has_error?(error_message, options = {})
      error_found = false
      if options[:field]
        first('.field.has-error', minimum: 1) # wait for any errors to come from validation
        all(".field.has-error").each do |field_container|

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

There are no issues that match your filters.

Category
Status