Cyclomatic complexity for join_reflection_without_through is too high. [9/6] Open
def join_reflection_without_through(reflection, table)
klass = reflection.active_record
other_class = reflection.klass
table1 = table || klass.arel_table- Read upRead up
- Exclude checks
This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.
An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.
Method has too many lines. [32/30] Open
def join_reflection_without_through(reflection, table)
klass = reflection.active_record
other_class = reflection.klass
table1 = table || klass.arel_table- Read upRead up
- Exclude checks
This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.
Method join_reflection_without_through has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
def join_reflection_without_through(reflection, table)
klass = reflection.active_record
other_class = reflection.klass
table1 = table || klass.arel_tableMethod join_reflection_without_through has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def join_reflection_without_through(reflection, table)
klass = reflection.active_record
other_class = reflection.klass
table1 = table || klass.arel_table- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method join_search_tables has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def join_search_tables klass, attributes: fields, table: klass.arel_table
attributes.each do |attribute|
if attribute.is_a? Hash
attribute.each_pair do |key, values|
reflection = klass.reflect_on_association(key.to_sym)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"