cucumber/cucumber-js

View on GitHub
src/formatter/json_formatter_spec.js

Summary

Maintainability
F
6 days
Test Coverage

File json_formatter_spec.js has 354 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import JsonFormatter from './json_formatter'
import Status from '../status'
import EventEmitter from 'events'
import Gherkin from 'gherkin'
import { EventDataCollector } from './helpers'
Severity: Minor
Found in src/formatter/json_formatter_spec.js - About 4 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        beforeEach(function() {
          const events = Gherkin.generateEvents(
            'Feature: my feature\n' +
              '  Scenario: my scenario\n' +
              '    Given my step\n' +
    Severity: Major
    Found in src/formatter/json_formatter_spec.js and 1 other location - About 1 day to fix
    src/formatter/json_formatter_spec.js on lines 318..358

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 342.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        beforeEach(function() {
          const events = Gherkin.generateEvents(
            'Feature: my feature\n' +
              '  Scenario: my scenario\n' +
              '    Given my step\n' +
    Severity: Major
    Found in src/formatter/json_formatter_spec.js and 1 other location - About 1 day to fix
    src/formatter/json_formatter_spec.js on lines 264..304

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 342.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          it('outputs the before hook with special properties', function() {
            const features = JSON.parse(this.output)
            const beforeHook = features[0].elements[0].steps[0]
            expect(beforeHook).to.not.have.ownProperty('line')
            expect(beforeHook.keyword).to.eql('Before')
    Severity: Major
    Found in src/formatter/json_formatter_spec.js and 1 other location - About 4 hrs to fix
    src/formatter/json_formatter_spec.js on lines 210..216

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 132.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          it('outputs the after hook with special properties', function() {
            const features = JSON.parse(this.output)
            const beforeHook = features[0].elements[0].steps[2]
            expect(beforeHook).to.not.have.ownProperty('line')
            expect(beforeHook.keyword).to.eql('After')
    Severity: Major
    Found in src/formatter/json_formatter_spec.js and 1 other location - About 4 hrs to fix
    src/formatter/json_formatter_spec.js on lines 202..208

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 132.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            this.eventBroadcaster.emit('test-step-attachment', {
              testCase: {
                sourceLocation: this.testCase.sourceLocation
              },
              index: 0,
    Severity: Major
    Found in src/formatter/json_formatter_spec.js and 1 other location - About 1 hr to fix
    src/formatter/json_formatter_spec.js on lines 238..245

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            this.eventBroadcaster.emit('test-step-attachment', {
              testCase: {
                sourceLocation: this.testCase.sourceLocation
              },
              index: 0,
    Severity: Major
    Found in src/formatter/json_formatter_spec.js and 1 other location - About 1 hr to fix
    src/formatter/json_formatter_spec.js on lines 230..237

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

            this.eventBroadcaster.emit('test-case-prepared', {
              sourceLocation: this.testCase.sourceLocation,
              steps: [
                {
                  sourceLocation: { uri: 'a.feature', line: 6 }
    Severity: Major
    Found in src/formatter/json_formatter_spec.js and 5 other locations - About 55 mins to fix
    src/formatter/json_formatter_spec.js on lines 57..64
    src/formatter/progress_bar_formatter_spec.js on lines 123..130
    src/formatter/progress_bar_formatter_spec.js on lines 268..275
    src/formatter/summary_formatter_spec.js on lines 86..93
    src/formatter/summary_formatter_spec.js on lines 133..140

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

            this.eventBroadcaster.emit('test-case-prepared', {
              sourceLocation: this.testCase.sourceLocation,
              steps: [
                {
                  sourceLocation: { uri: 'a.feature', line: 6 }
    Severity: Major
    Found in src/formatter/json_formatter_spec.js and 5 other locations - About 55 mins to fix
    src/formatter/json_formatter_spec.js on lines 117..124
    src/formatter/progress_bar_formatter_spec.js on lines 123..130
    src/formatter/progress_bar_formatter_spec.js on lines 268..275
    src/formatter/summary_formatter_spec.js on lines 86..93
    src/formatter/summary_formatter_spec.js on lines 133..140

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

            this.eventBroadcaster.emit('test-case-finished', {
              sourceLocation: this.testCase.sourceLocation,
              result: { duration: 1, status: Status.PASSED }
            })
    Severity: Major
    Found in src/formatter/json_formatter_spec.js and 4 other locations - About 45 mins to fix
    src/formatter/json_formatter_spec.js on lines 70..73
    src/formatter/json_formatter_spec.js on lines 130..133
    src/formatter/json_formatter_spec.js on lines 163..166
    src/formatter/json_formatter_spec.js on lines 195..198

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

            this.eventBroadcaster.emit('test-case-finished', {
              sourceLocation: this.testCase.sourceLocation,
              result: { duration: 1, status: Status.PASSED }
            })
    Severity: Major
    Found in src/formatter/json_formatter_spec.js and 4 other locations - About 45 mins to fix
    src/formatter/json_formatter_spec.js on lines 70..73
    src/formatter/json_formatter_spec.js on lines 130..133
    src/formatter/json_formatter_spec.js on lines 195..198
    src/formatter/json_formatter_spec.js on lines 246..249

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

            this.eventBroadcaster.emit('test-case-finished', {
              sourceLocation: this.testCase.sourceLocation,
              result: { duration: 1, status: Status.PASSED }
            })
    Severity: Major
    Found in src/formatter/json_formatter_spec.js and 4 other locations - About 45 mins to fix
    src/formatter/json_formatter_spec.js on lines 130..133
    src/formatter/json_formatter_spec.js on lines 163..166
    src/formatter/json_formatter_spec.js on lines 195..198
    src/formatter/json_formatter_spec.js on lines 246..249

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

            this.eventBroadcaster.emit('test-case-finished', {
              sourceLocation: this.testCase.sourceLocation,
              result: { duration: 1, status: Status.PASSED }
            })
    Severity: Major
    Found in src/formatter/json_formatter_spec.js and 4 other locations - About 45 mins to fix
    src/formatter/json_formatter_spec.js on lines 70..73
    src/formatter/json_formatter_spec.js on lines 130..133
    src/formatter/json_formatter_spec.js on lines 163..166
    src/formatter/json_formatter_spec.js on lines 246..249

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

            this.eventBroadcaster.emit('test-case-finished', {
              sourceLocation: this.testCase.sourceLocation,
              result: { duration: 1, status: Status.FAILED }
            })
    Severity: Major
    Found in src/formatter/json_formatter_spec.js and 4 other locations - About 45 mins to fix
    src/formatter/json_formatter_spec.js on lines 70..73
    src/formatter/json_formatter_spec.js on lines 163..166
    src/formatter/json_formatter_spec.js on lines 195..198
    src/formatter/json_formatter_spec.js on lines 246..249

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status