cuebook/CueObserve

View on GitHub
api/anomaly/services/anomalyDefinitions.py

Summary

Maintainability
A
1 hr
Test Coverage
A
90%

Function addAnomalyDefinition has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def addAnomalyDefinition(
Severity: Major
Found in api/anomaly/services/anomalyDefinitions.py - About 50 mins to fix

    Function sortOnAnomalyDefinition has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def sortOnAnomalyDefinition(anomalyDefObjs: List[AnomalyDefinition], sorter):
            """
            Sort Anomaly Definition on given user column
            """
            columnToSort = sorter.get("columnKey", "")
    Severity: Minor
    Found in api/anomaly/services/anomalyDefinitions.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function editAnomalyDefinition has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def editAnomalyDefinition(
            anomalyId: int = 0, highOrLow: str = None, detectionRuleParams: dict = {}
        ):
            """
            Update anomaly objects of given anomalyId
    Severity: Minor
    Found in api/anomaly/services/anomalyDefinitions.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status