cvent/octopus-deploy-cookbook

View on GitHub

Showing 40 of 40 total issues

Class has too many lines. [109/100]
Open

class ServerScripts < TemplateScripts
  def create_instance(resource)
    generate_script(create, binding)
  end

Severity: Minor
Found in libraries/server_scripts.rb by rubocop

This cop checks if the length a class exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Block has too many lines. [79/25]
Open

describe 'OctopusDeploy::Tentacle' do
  let(:tentacle) { Class.new { include OctopusDeploy::Tentacle }.new }

  describe 'display_name' do
    it 'should return the correct display name' do
Severity: Minor
Found in spec/unit/lib_tentacle_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Block has too many lines. [58/25]
Open

describe 'OctopusDeploy::Shared' do
  let(:shared) { Class.new { include OctopusDeploy::Shared }.new }

  describe 'powershell_boolean' do
    it 'should return uppercased bools' do
Severity: Minor
Found in spec/unit/lib_shared_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Block has too many lines. [53/25]
Open

action :configure do
  action_install

  port = resolve_port(new_resource.polling, new_resource.port)
  service_name = service_name(new_resource.instance)
Severity: Minor
Found in resources/tentacle.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Nokogiri gem, via libxslt, is affected by improper access control vulnerability
Open

    nokogiri (1.10.1)
Severity: Minor
Found in Gemfile.lock by bundler-audit

Advisory: CVE-2019-11068

URL: https://github.com/sparklemotion/nokogiri/issues/1892

Solution: upgrade to >= 1.10.3

Block has too many lines. [26/25]
Open

describe 'OctopusDeploy::Server' do
  let(:server) { Class.new { include OctopusDeploy::Server }.new }

  describe 'display_name' do
    it 'should return the correct display name' do
Severity: Minor
Found in spec/unit/lib_server_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Add an empty line after magic comments.
Open

#
Severity: Minor
Found in libraries/tentacle.rb by rubocop

Checks for a newline after the final magic comment.

Example:

# good
# frozen_string_literal: true

# Some documentation for Person
class Person
  # Some code
end

# bad
# frozen_string_literal: true
# Some documentation for Person
class Person
  # Some code
end

When using method_missing, define respond_to_missing? and fall back on super.
Open

      def method_missing(method_name)
        method_name.to_s
      end

This cop checks for the presence of method_missing without also defining respond_to_missing? and falling back on super.

Example:

#bad
def method_missing(name, *args)
  # ...
end

#good
def respond_to_missing?(name, include_private)
  # ...
end

def method_missing(name, *args)
  # ...
  super
end

Add an empty line after magic comments.
Open

require 'spec_helper'
Severity: Minor
Found in spec/unit/lib_tentacle_spec.rb by rubocop

Checks for a newline after the final magic comment.

Example:

# good
# frozen_string_literal: true

# Some documentation for Person
class Person
  # Some code
end

# bad
# frozen_string_literal: true
# Some documentation for Person
class Person
  # Some code
end

%w-literals should be delimited by [ and ].
Open

      options = %w(option1 option2)
Severity: Minor
Found in spec/unit/lib_shared_spec.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

Add an empty line after magic comments.
Open

#
Severity: Minor
Found in libraries/server.rb by rubocop

Checks for a newline after the final magic comment.

Example:

# good
# frozen_string_literal: true

# Some documentation for Person
class Person
  # Some code
end

# bad
# frozen_string_literal: true
# Some documentation for Person
class Person
  # Some code
end

include is used at the top level. Use inside class or module.
Open

include OctopusDeploy::Tentacle
Severity: Minor
Found in resources/tentacle.rb by rubocop

This cop checks that include, extend and prepend exists at the top level. Using these at the top level affects the behavior of Object. There will not be using include, extend and prepend at the top level. Let's use it inside class or module.

Example:

# bad
include M

class C
end

# bad
extend M

class C
end

# bad
prepend M

class C
end

# good
class C
  include M
end

# good
class C
  extend M
end

# good
class C
  prepend M
end

Add an empty line after magic comments.
Open

#
Severity: Minor
Found in libraries/shared.rb by rubocop

Checks for a newline after the final magic comment.

Example:

# good
# frozen_string_literal: true

# Some documentation for Person
class Person
  # Some code
end

# bad
# frozen_string_literal: true
# Some documentation for Person
class Person
  # Some code
end

Use meaningful heredoc delimiters.
Open

    EOH
Severity: Minor
Found in resources/tentacle.rb by rubocop

This cop checks that your heredocs are using meaningful delimiters. By default it disallows END and EO*, and can be configured through blacklisting additional delimiters.

Example:

# good
<

Add an empty line after magic comments.
Open

#
Severity: Minor
Found in resources/tentacle.rb by rubocop

Checks for a newline after the final magic comment.

Example:

# good
# frozen_string_literal: true

# Some documentation for Person
class Person
  # Some code
end

# bad
# frozen_string_literal: true
# Some documentation for Person
class Person
  # Some code
end

Use meaningful heredoc delimiters.
Open

    EOH
Severity: Minor
Found in resources/tentacle.rb by rubocop

This cop checks that your heredocs are using meaningful delimiters. By default it disallows END and EO*, and can be configured through blacklisting additional delimiters.

Example:

# good
<

Add an empty line after magic comments.
Open

require 'spec_helper'
Severity: Minor
Found in spec/unit/lib_shared_spec.rb by rubocop

Checks for a newline after the final magic comment.

Example:

# good
# frozen_string_literal: true

# Some documentation for Person
class Person
  # Some code
end

# bad
# frozen_string_literal: true
# Some documentation for Person
class Person
  # Some code
end

Use meaningful heredoc delimiters.
Open

    EOH
Severity: Minor
Found in resources/tentacle.rb by rubocop

This cop checks that your heredocs are using meaningful delimiters. By default it disallows END and EO*, and can be configured through blacklisting additional delimiters.

Example:

# good
<

Use meaningful heredoc delimiters.
Open

    EOH
Severity: Minor
Found in resources/tentacle.rb by rubocop

This cop checks that your heredocs are using meaningful delimiters. By default it disallows END and EO*, and can be configured through blacklisting additional delimiters.

Example:

# good
<

%w-literals should be delimited by [ and ].
Open

    config.enhancement_labels = %w(enhancement)
Severity: Minor
Found in tasks/changelog.rake by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)
Severity
Category
Status
Source
Language