Sign upLogin

daften/addressing-bundle

View on GitHub
Star

Showing 213 of 213 total issues

The variable $subdivision_fields is not named in camelCase.
Open

    protected function getValuesForDefault(AddressEmbeddable $addressEmbeddable, AddressFormat $address_format) {
        $values = [];
        foreach (AddressField::getAll() as $field) {
            $getter = 'get' . ucfirst($field);
            $values[$field] = $addressEmbeddable->$getter();
Severity: Minor
Found in Service/AddressOutputService.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $address_format is not named in camelCase.
Open

    public function getAddressPlain(AddressEmbeddable $addressEmbeddable): array
    {
        $country_code = $addressEmbeddable->getCountryCode();
        $countries = $this->countryRepository->getList();
        $address_format = $this->addressFormatRepository->get($country_code);
Severity: Minor
Found in Service/AddressOutputService.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $original_values is not named in camelCase.
Open

    protected function getValuesForPlain(AddressEmbeddable $addressEmbeddable, AddressFormat $address_format) {
        $values = [];
        foreach (AddressField::getAll() as $field) {
            $getter = 'get' . ucfirst($field);
            $values[$field] = $addressEmbeddable->$getter();
Severity: Minor
Found in Service/AddressOutputService.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $unused_fields is not named in camelCase.
Open

    protected function getValuesForPlain(AddressEmbeddable $addressEmbeddable, AddressFormat $address_format) {
        $values = [];
        foreach (AddressField::getAll() as $field) {
            $getter = 'get' . ucfirst($field);
            $values[$field] = $addressEmbeddable->$getter();
Severity: Minor
Found in Service/AddressOutputService.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $format_string is not named in camelCase.
Open

    public function getAddressDefault(AddressEmbeddable $addressEmbeddable): string
    {
        $country_code = $addressEmbeddable->getCountryCode();
        $address_format = $this->addressFormatRepository->get($country_code);
Severity: Minor
Found in Service/AddressOutputService.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $country_code is not named in camelCase.
Open

    public function getAddressPlain(AddressEmbeddable $addressEmbeddable): array
    {
        $country_code = $addressEmbeddable->getCountryCode();
        $countries = $this->countryRepository->getList();
        $address_format = $this->addressFormatRepository->get($country_code);
Severity: Minor
Found in Service/AddressOutputService.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $format_string is not named in camelCase.
Open

    public function getAddressInline(AddressEmbeddable $addressEmbeddable): string
    {
        $country_code = $addressEmbeddable->getCountryCode();
        $address_format = $this->addressFormatRepository->get($country_code);
Severity: Minor
Found in Service/AddressOutputService.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $original_values is not named in camelCase.
Open

    protected function getValuesForDefault(AddressEmbeddable $addressEmbeddable, AddressFormat $address_format) {
        $values = [];
        foreach (AddressField::getAll() as $field) {
            $getter = 'get' . ucfirst($field);
            $values[$field] = $addressEmbeddable->$getter();
Severity: Minor
Found in Service/AddressOutputService.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $element_options is not named in camelCase.
Open

    public function preSetData(FormEvent $event): void
    {
        /** @var AddressEmbeddable $address */
        $address = $event->getData();
        $form = $event->getForm();
Severity: Minor
Found in Form/EventListener/AddressEmbeddableTypeSubscriber.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $all_fields is not named in camelCase.
Open

    public function preSubmit(FormEvent $event): void
    {
        $data = $event->getData();
        if (!is_array($data) || !array_key_exists('countryCode', $data)) {
            return;
Severity: Minor
Found in Form/EventListener/AddressEmbeddableTypeSubscriber.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $line_fields is not named in camelCase.
Open

    public function preSubmit(FormEvent $event): void
    {
        $data = $event->getData();
        if (!is_array($data) || !array_key_exists('countryCode', $data)) {
            return;
Severity: Minor
Found in Form/EventListener/AddressEmbeddableTypeSubscriber.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $element_options is not named in camelCase.
Open

    public function preSetData(FormEvent $event): void
    {
        /** @var AddressEmbeddable $address */
        $address = $event->getData();
        $form = $event->getForm();
Severity: Minor
Found in Form/EventListener/AddressEmbeddableTypeSubscriber.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $field_index is not named in camelCase.
Open

    public function preSetData(FormEvent $event): void
    {
        /** @var AddressEmbeddable $address */
        $address = $event->getData();
        $form = $event->getForm();
Severity: Minor
Found in Form/EventListener/AddressEmbeddableTypeSubscriber.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $line_index is not named in camelCase.
Open

    public function preSubmit(FormEvent $event): void
    {
        $data = $event->getData();
        if (!is_array($data) || !array_key_exists('countryCode', $data)) {
            return;
Severity: Minor
Found in Form/EventListener/AddressEmbeddableTypeSubscriber.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $line_fields is not named in camelCase.
Open

    public function preSetData(FormEvent $event): void
    {
        /** @var AddressEmbeddable $address */
        $address = $event->getData();
        $form = $event->getForm();
Severity: Minor
Found in Form/EventListener/AddressEmbeddableTypeSubscriber.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $element_options is not named in camelCase.
Open

    public function preSetData(FormEvent $event): void
    {
        /** @var AddressEmbeddable $address */
        $address = $event->getData();
        $form = $event->getForm();
Severity: Minor
Found in Form/EventListener/AddressEmbeddableTypeSubscriber.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $line_index is not named in camelCase.
Open

    public function preSetData(FormEvent $event): void
    {
        /** @var AddressEmbeddable $address */
        $address = $event->getData();
        $form = $event->getForm();
Severity: Minor
Found in Form/EventListener/AddressEmbeddableTypeSubscriber.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $all_fields is not named in camelCase.
Open

    public function preSubmit(FormEvent $event): void
    {
        $data = $event->getData();
        if (!is_array($data) || !array_key_exists('countryCode', $data)) {
            return;
Severity: Minor
Found in Form/EventListener/AddressEmbeddableTypeSubscriber.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $address_default is not named in camelCase.
Open

    public function buildForm(FormBuilderInterface $builder, array $options)
    {
        $builder
            ->add('addressAutocomplete', TextType::class, [
                'mapped' => false,
Severity: Minor
Found in Form/Type/AddressEmbeddableGmapsAutocompleteType.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $unused_fields is not named in camelCase.
Open

    public function preSubmit(FormEvent $event): void
    {
        $data = $event->getData();
        if (!is_array($data) || !array_key_exists('countryCode', $data)) {
            return;
Severity: Minor
Found in Form/EventListener/AddressEmbeddableTypeSubscriber.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

Severity
Category
Status
Source
Language