Showing 213 of 213 total issues
Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
CountryRepositoryInterface $countryRepository,
AddressFormatRepositoryInterface $addressFormatRepository,
SubdivisionRepositoryInterface $subdivisionRepository,
string $gmapsApiKey,
RequestStack $requestStackTRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL" Open
$values[$name] = NULL;- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
$content = nl2br($content, FALSE);- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL" Open
return isset($property_mapping[$field]) ? $property_mapping[$field] : NULL;- Exclude checks
The closing brace for the class must go on the next line after the body Open
}- Exclude checks
Expected 1 space before opening brace; found 0 Open
function (FormEvent $event){- Exclude checks
Opening brace of a class must be on the line after the definition Open
class FieldHelper {- Exclude checks
The closing brace for the class must go on the next line after the body Open
}- Exclude checks
Avoid too many return statements within this method. Open
return new FieldOverrides([]);Avoid too many return statements within this method. Open
return $constraint->fieldOverrides;Function getAddressDefault has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public function getAddressDefault(AddressEmbeddable $addressEmbeddable): string
{
$country_code = $addressEmbeddable->getCountryCode();
$address_format = $this->addressFormatRepository->get($country_code);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid using static access to class '\CommerceGuys\Addressing\AddressFormat\AddressField' in method 'getValuesForDefault'. Open
foreach (AddressField::getAll() as $field) {- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid unused local variables such as '$address'. Open
$use_local_name = Locale::matchCandidates($address->getLocale(), $subdivision->getLocale());- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid using static access to class '\CommerceGuys\Addressing\AddressFormat\AddressField' in method 'getValuesForPlain'. Open
foreach (AddressField::getAll() as $field) {- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\Daften\Bundle\AddressingBundle\FieldHelper' in method 'getAddressDefault'. Open
$content = FieldHelper::replacePlaceholders($format_string, $replacements);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\Daften\Bundle\AddressingBundle\FieldHelper' in method 'getAddressDefault'. Open
$property = FieldHelper::getPropertyName($field);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\Daften\Bundle\AddressingBundle\FieldHelper' in method 'getAddressInline'. Open
$content = FieldHelper::replacePlaceholders($format_string, $replacements);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The method getAddressInline uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
else {
$format_string = $address_format->getFormat() . "\n" . '%country';
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class '\CommerceGuys\Addressing\Locale' in method 'getValuesForDefault'. Open
$use_local_name = Locale::matchCandidates($address->getLocale(), $subdivision->getLocale());- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The method getAddressDefault uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
else {
$format_string = $address_format->getFormat() . "\n" . '%country';
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}