dalpo/rails_admin_nestable

View on GitHub

Showing 7 of 17 total issues

File jquery.nestable.js has 393 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*!
 * Nestable jQuery Plugin - Copyright (c) 2012 David Bushell - http://dbushell.com/
 * Dual-licensed under the BSD or MIT licenses
 */
;(function($, window, document, undefined)
Severity: Minor
Found in app/assets/javascripts/rails_admin/jquery.nestable.js - About 5 hrs to fix

    Function dragMove has 117 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            dragMove: function(e)
            {
                var list, parent, prev, next, depth,
                    opt   = this.options,
                    mouse = this.mouse;
    Severity: Major
    Found in app/assets/javascripts/rails_admin/jquery.nestable.js - About 4 hrs to fix

      Function init has 60 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              init: function()
              {
                  var list = this;
      
                  list.reset();
      Severity: Major
      Found in app/assets/javascripts/rails_admin/jquery.nestable.js - About 2 hrs to fix

        Method update_tree has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

                    def update_tree(tree_nodes, parent_node = nil)
                      tree_nodes.each do |key, value|
                        model = @abstract_model.model.find(value['id'].to_s)
                        model.parent = parent_node || nil
                        model.send("#{@position_field}=".to_sym, (key.to_i + 1)) if @position_field.present?
        Severity: Minor
        Found in lib/rails_admin_nestable/nestable.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function dragStart has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                dragStart: function(e)
                {
                    var mouse    = this.mouse,
                        target   = $(e.target),
                        dragItem = target.closest(this.options.itemNodeName);
        Severity: Minor
        Found in app/assets/javascripts/rails_admin/jquery.nestable.js - About 1 hr to fix

          Consider simplifying this complex logical expression.
          Open

                          if (!handle.length || list.dragEl || (!hasTouch && e.button !== 0) || (hasTouch && e.touches.length !== 1)) {
                              return;
                          }
          Severity: Major
          Found in app/assets/javascripts/rails_admin/jquery.nestable.js - About 40 mins to fix

            Method nested_tree_nodes has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def nested_tree_nodes(tree_nodes = [])
                  return if tree_nodes.nil?
                  tree_nodes.map do |tree_node, sub_tree_nodes|
                    li_classes = 'dd-item dd3-item'
            
            
            Severity: Minor
            Found in lib/rails_admin_nestable/helper.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language