Sign upLogin

danielwippermann/resol-vbus

View on GitHub
Star
src/configuration-optimizers/resol-deltasol-slt-102-configuration-optimizer.js

Summary

Maintainability
F
3 days
Test Coverage

Identical blocks of code found in 3 locations. Consider refactoring.
Open

    optimizeAnlageWfConfiguration($) {
        $(/^(Anlage_Wf[0-9]+)_Type$/).forEach((value) => {
            const prefix = '^' + value.md [1] + '_';

            value.eql('#Frei', () => {
Severity: Major
Found in src/configuration-optimizers/resol-deltasol-slt-102-configuration-optimizer.js and 2 other locations - About 1 day to fix
src/configuration-optimizers/resol-deltasol-bx-plus-xxx-configuration-optimizer.js on lines 97..127
src/configuration-optimizers/resol-deltasol-mx-112-configuration-optimizer.js on lines 105..135

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 203.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

    optimizeHeizungWfConfiguration($) {
        $(/^(Heizung_Wf[0-9]+)_Type$/).forEach((value) => {
            const prefix = '^' + value.md [1] + '_';

            value.eql('#Frei', () => {
Severity: Major
Found in src/configuration-optimizers/resol-deltasol-slt-102-configuration-optimizer.js and 2 other locations - About 1 day to fix
src/configuration-optimizers/resol-deltasol-bx-plus-xxx-configuration-optimizer.js on lines 129..152
src/configuration-optimizers/resol-deltasol-mx-112-configuration-optimizer.js on lines 137..160

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 196.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

    optimizeSolarWfConfiguration($) {
        $(/^Solar_Wf([0-9]+)_Type$/).forEach((value) => {
            const prefix = '^Solar_Wf' + value.md [1] + '_';

            value.in([ 0, '#Frei' ], () => {
Severity: Major
Found in src/configuration-optimizers/resol-deltasol-slt-102-configuration-optimizer.js and 3 other locations - About 6 hrs to fix
src/configuration-optimizers/resol-deltasol-bx-plus-xxx-configuration-optimizer.js on lines 73..95
src/configuration-optimizers/resol-deltasol-mx-112-configuration-optimizer.js on lines 81..103
src/configuration-optimizers/resol-deltasol-mx-2xx-configuration-optimizer.js on lines 96..118

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 160.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 5 locations. Consider refactoring.
Open

    optimizeWmzConfiguration($) {
        $(/^(Wmz[0-9]+)_Type$/).forEach((value) => {
            const prefix = '^' + value.md [1] + '_';

            value.eql(0, () => {
Severity: Major
Found in src/configuration-optimizers/resol-deltasol-slt-102-configuration-optimizer.js and 4 other locations - About 2 hrs to fix
src/configuration-optimizers/resol-deltasol-bx-plus-xxx-configuration-optimizer.js on lines 180..188
src/configuration-optimizers/resol-deltasol-mx-112-configuration-optimizer.js on lines 188..196
src/configuration-optimizers/resol-deltasol-mx-2xx-configuration-optimizer.js on lines 213..221
src/configuration-optimizers/resol-deltatherm-hc-xxx-configuration-optimizer.js on lines 101..109

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 88.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

        value.isChanged(() => {
            $(/^Solar_.*/).invalidate();
            $(/^Anlage_.*/).invalidate();
            $(/^Heizung_.*/).invalidate();
        });
Severity: Major
Found in src/configuration-optimizers/resol-deltasol-slt-102-configuration-optimizer.js and 3 other locations - About 1 hr to fix
src/configuration-optimizers/resol-deltasol-bx-plus-xxx-configuration-optimizer.js on lines 31..35
src/configuration-optimizers/resol-deltasol-mx-112-configuration-optimizer.js on lines 31..35
src/configuration-optimizers/resol-deltasol-mx-2xx-configuration-optimizer.js on lines 42..46

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 58.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

        value.lt(30, () => {
            $(/^Solar_Sp2_.*/).ignore();
            // TODO: Ladelogik
            $(/^Solar_Wf2_(ExtWT)_.*/).ignore();
        });
Severity: Major
Found in src/configuration-optimizers/resol-deltasol-slt-102-configuration-optimizer.js and 2 other locations - About 40 mins to fix
src/configuration-optimizers/resol-deltasol-bx-plus-xxx-configuration-optimizer.js on lines 54..58
src/configuration-optimizers/resol-deltasol-mx-112-configuration-optimizer.js on lines 58..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

        value.lt(10, () => {
            $(/^Solar_Sp1_.*/).ignore();
            $(/^Solar_Wf1_(ExtWT)_.*/).ignore();
        });
Severity: Major
Found in src/configuration-optimizers/resol-deltasol-slt-102-configuration-optimizer.js and 10 other locations - About 30 mins to fix
src/configuration-optimizers/resol-deltasol-bx-plus-xxx-configuration-optimizer.js on lines 41..44
src/configuration-optimizers/resol-deltasol-bx-plus-xxx-configuration-optimizer.js on lines 50..53
src/configuration-optimizers/resol-deltasol-bx-plus-xxx-configuration-optimizer.js on lines 59..62
src/configuration-optimizers/resol-deltasol-bx-plus-xxx-configuration-optimizer.js on lines 63..66
src/configuration-optimizers/resol-deltasol-mx-112-configuration-optimizer.js on lines 41..44
src/configuration-optimizers/resol-deltasol-mx-112-configuration-optimizer.js on lines 54..57
src/configuration-optimizers/resol-deltasol-mx-112-configuration-optimizer.js on lines 63..66
src/configuration-optimizers/resol-deltasol-mx-112-configuration-optimizer.js on lines 67..70
src/configuration-optimizers/resol-deltasol-mx-112-configuration-optimizer.js on lines 71..74
src/configuration-optimizers/resol-deltasol-slt-102-configuration-optimizer.js on lines 33..36

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

        value.check(hasSecondKollektor, () => {
            $(/^Solar_Kol2_.*/).ignore();
            $(/^Solar_Wf2_(Roehrenkollektor|Bypass|Frostschutz)_.*/).ignore();
        });
Severity: Minor
Found in src/configuration-optimizers/resol-deltasol-slt-102-configuration-optimizer.js and 2 other locations - About 30 mins to fix
src/configuration-optimizers/resol-deltasol-bx-plus-xxx-configuration-optimizer.js on lines 45..48
src/configuration-optimizers/resol-deltasol-mx-112-configuration-optimizer.js on lines 45..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

        value.lt(10, () => {
            $(/^Solar_Kol1_.*/).ignore();
            $(/^Solar_Wf1_(Roehrenkollektor|Bypass|Frostschutz)_.*/).ignore();
        });
Severity: Major
Found in src/configuration-optimizers/resol-deltasol-slt-102-configuration-optimizer.js and 10 other locations - About 30 mins to fix
src/configuration-optimizers/resol-deltasol-bx-plus-xxx-configuration-optimizer.js on lines 41..44
src/configuration-optimizers/resol-deltasol-bx-plus-xxx-configuration-optimizer.js on lines 50..53
src/configuration-optimizers/resol-deltasol-bx-plus-xxx-configuration-optimizer.js on lines 59..62
src/configuration-optimizers/resol-deltasol-bx-plus-xxx-configuration-optimizer.js on lines 63..66
src/configuration-optimizers/resol-deltasol-mx-112-configuration-optimizer.js on lines 41..44
src/configuration-optimizers/resol-deltasol-mx-112-configuration-optimizer.js on lines 54..57
src/configuration-optimizers/resol-deltasol-mx-112-configuration-optimizer.js on lines 63..66
src/configuration-optimizers/resol-deltasol-mx-112-configuration-optimizer.js on lines 67..70
src/configuration-optimizers/resol-deltasol-mx-112-configuration-optimizer.js on lines 71..74
src/configuration-optimizers/resol-deltasol-slt-102-configuration-optimizer.js on lines 42..45

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status