danmcclain/postgres_ext

View on GitHub

Showing 14 of 14 total issues

Method build has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

    def self.build(attribute, value)
      case value
      when Array
        column = case attribute.try(:relation)
                 when Arel::Nodes::TableAlias, NilClass
Severity: Minor
Found in lib/postgres_ext/active_record/relation/predicate_builder.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      def contained_in_array(opts, *rest)
        build_where_chain(opts, rest) do |rel|
          case rel
          when Arel::Nodes::In, Arel::Nodes::Equality
            column = left_column(rel) || column_from_association(rel)
Severity: Major
Found in lib/postgres_ext/active_record/relation/query_methods.rb and 1 other location - About 1 hr to fix
lib/postgres_ext/active_record/relation/query_methods.rb on lines 16..31

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      def contains(opts, *rest)
        build_where_chain(opts, rest) do |rel|
          case rel
          when Arel::Nodes::In, Arel::Nodes::Equality
            column = left_column(rel) || column_from_association(rel)
Severity: Major
Found in lib/postgres_ext/active_record/relation/query_methods.rb and 1 other location - About 1 hr to fix
lib/postgres_ext/active_record/relation/query_methods.rb on lines 36..51

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method build has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def self.build(attribute, value)
      case value
      when Array
        column = case attribute.try(:relation)
                 when Arel::Nodes::TableAlias, NilClass
Severity: Minor
Found in lib/postgres_ext/active_record/relation/predicate_builder.rb - About 1 hr to fix

    Method build_rank has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        def build_rank(arel, rank_window_options)
          unless arel.projections.count == 1 && Arel::Nodes::Count === arel.projections.first
            rank_window = case rank_window_options
                          when :order
                            arel.orders
    Severity: Minor
    Found in lib/postgres_ext/active_record/relation/query_methods.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method contains has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

          def contains(opts, *rest)
            build_where_chain(opts, rest) do |rel|
              case rel
              when Arel::Nodes::In, Arel::Nodes::Equality
                column = left_column(rel) || column_from_association(rel)
    Severity: Minor
    Found in lib/postgres_ext/active_record/relation/query_methods.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method contained_in_array has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

          def contained_in_array(opts, *rest)
            build_where_chain(opts, rest) do |rel|
              case rel
              when Arel::Nodes::In, Arel::Nodes::Equality
                column = left_column(rel) || column_from_association(rel)
    Severity: Minor
    Found in lib/postgres_ext/active_record/relation/query_methods.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method call_with_feature has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

            def call_with_feature(attribute, value)
              column = case attribute.try(:relation)
                       when Arel::Nodes::TableAlias, NilClass
                       else
                         cache = attribute.relation.engine.connection.schema_cache

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method build_with has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def build_with(arel)
          with_statements = with_values.flat_map do |with_value|
            case with_value
            when String
              with_value
    Severity: Minor
    Found in lib/postgres_ext/active_record/relation/query_methods.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            column = case attribute.try(:relation)
                     when Arel::Nodes::TableAlias, NilClass
                     else
                       cache = attribute.relation.engine.connection.schema_cache
                       if cache.table_exists? attribute.relation.name
    Severity: Minor
    Found in lib/postgres_ext/active_record/relation/predicate_builder.rb and 1 other location - About 45 mins to fix
    lib/postgres_ext/active_record/relation/predicate_builder/array_handler.rb on lines 13..18

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 39.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

              column = case attribute.try(:relation)
                       when Arel::Nodes::TableAlias, NilClass
                       else
                         cache = attribute.relation.engine.connection.schema_cache
                         if cache.table_exists? attribute.relation.name
    lib/postgres_ext/active_record/relation/predicate_builder.rb on lines 8..13

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 39.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method visit_Array has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def visit_Array o, a
            column = case a.try(:relation)
                     when Arel::Nodes::TableAlias, NilClass
                     # noop Prevent from searching for table alias name in schema cache
                     # which won't exist for aliased table when used with Single Table
    Severity: Minor
    Found in lib/postgres_ext/arel/4.1/visitors/postgresql.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method equality_for_hstore has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def equality_for_hstore(rel)
            new_right_name = rel.left.name.to_s
            if rel.right.respond_to?(:val)
              return if rel.right.val.is_a?(Hash)
              rel.right = Arel::Nodes.build_quoted({new_right_name => rel.right.val},
    Severity: Minor
    Found in lib/postgres_ext/active_record/relation/query_methods.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method visit_Arel_Nodes_Contains has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def visit_Arel_Nodes_Contains o, collector
            left_column = o.left.relation.engine.columns.find do |col|
              col.name == o.left.name.to_s || col.name == o.left.relation.name.to_s
            end
    
    
    Severity: Minor
    Found in lib/postgres_ext/arel/4.2/visitors/postgresql.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language