dannyvankooten/AltoRouter

View on GitHub

Showing 4 of 4 total issues

Function match has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

    public function match($requestUrl = null, $requestMethod = null)
    {

        $params = [];

Severity: Minor
Found in AltoRouter.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method match has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function match($requestUrl = null, $requestMethod = null)
    {

        $params = [];

Severity: Minor
Found in AltoRouter.php - About 1 hr to fix

    Function generate has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        public function generate($routeName, array $params = [])
        {
    
            // Check if named route exists
            if (!isset($this->namedRoutes[$routeName])) {
    Severity: Minor
    Found in AltoRouter.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function compileRoute has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function compileRoute($route)
        {
            if (preg_match_all('`(/|\.|)\[([^:\]]*+)(?::([^:\]]*+))?\](\?|)`', $route, $matches, PREG_SET_ORDER)) {
                $matchTypes = $this->matchTypes;
                foreach ($matches as $match) {
    Severity: Minor
    Found in AltoRouter.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language