datacite/spinone

View on GitHub

Showing 22 of 41 total issues

Method get_query_url has a Cognitive Complexity of 93 (exceeds 5 allowed). Consider refactoring.
Open

  def self.get_query_url(options={})
    if options[:id].present?
      params = { q: "doi:#{options[:id]}",
                 wt: "json" }
    elsif options[:work_id].present?
Severity: Minor
Found in app/models/work.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse_data has a Cognitive Complexity of 56 (exceeds 5 allowed). Consider refactoring.
Open

  def self.parse_data(result, options={})
    return result if result['errors']
    data = nil

    if options[:id].present?
Severity: Minor
Found in app/models/work.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_query_url has 110 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.get_query_url(options={})
    if options[:id].present?
      params = { q: "doi:#{options[:id]}",
                 wt: "json" }
    elsif options[:work_id].present?
Severity: Major
Found in app/models/work.rb - About 4 hrs to fix

    File work.rb has 342 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class Work < Base
      attr_reader :id, :doi, :identifier, :cache_key, :url, :author, :title, :container_title, :description, :resource_type_subtype, :data_center_id, :member_id, :resource_type_id, :data_center, :member, :resource_type, :license, :version, :results, :related_identifiers, :schema_version, :xml, :media, :checked, :published, :registered, :updated
    
      # include author methods
      include Authorable
    Severity: Minor
    Found in app/models/work.rb - About 4 hrs to fix

      Method parse_data has 74 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def self.parse_data(result, options={})
          return result if result['errors']
          data = nil
      
          if options[:id].present?
      Severity: Major
      Found in app/models/work.rb - About 2 hrs to fix

        Method normalize_license has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

          def normalize_license(licenses)
            uri = licenses.map { |l| URI.parse(l) }.find { |l| l.host && l.host[/(creativecommons.org|opensource.org)$/] }
            return nil unless uri.present?
        
            # use HTTPS
        Severity: Minor
        Found in app/models/work.rb - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method parse_data has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

          def self.parse_data(result, options={})
            return nil if result.body.blank? || result.body['errors']
        
            items = result.body.fetch("data", [])
        
        
        Severity: Minor
        Found in app/models/page.rb - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method initialize has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def initialize(attributes={}, options={})
            @doi = attributes.fetch("doi", "").downcase.presence
            @identifier = attributes.fetch("id", nil).presence || doi_as_url(attributes.fetch("doi", nil))
            @id = @identifier
        
        
        Severity: Minor
        Found in app/models/work.rb - About 1 hr to fix

          Method get_one_author has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

              def get_one_author(author)
                name = cleanup_author(author)
          
                if is_personal_name?(name)
                  names = Namae.parse(name)
          Severity: Minor
          Found in app/models/concerns/authorable.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method parse_facet_counts has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def self.parse_facet_counts(facets, options={})
              resource_types = Array.wrap(facets.dig("facet_fields", "resourceType_facet"))
                                     .each_slice(2)
                                     .map { |k,v| { id: k.underscore.dasherize, title: k.underscore.humanize, count: v } }
              registered = Array.wrap(facets.dig("facet_ranges", "minted", "counts"))
          Severity: Minor
          Found in app/models/work.rb - About 1 hr to fix

            Method parse_data has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

              def self.parse_data(result, options={})
                return nil if result.body.blank? || result.body['errors']
            
                if options[:id].present?
                  item = result.body.fetch("data", {})
            Severity: Minor
            Found in app/models/milestone.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method get_datetime_from_iso8601 has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                def get_datetime_from_iso8601(iso8601_time, options={})
                  if options[:until_date]
                    if iso8601_time[8..9].present?
                      ISO8601::DateTime.new(iso8601_time).to_time.utc.at_end_of_day
                    elsif iso8601_time[5..6].present?
            Severity: Minor
            Found in app/models/concerns/dateable.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method get_query_url has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

              def self.get_query_url(options={})
                if options[:id].present?
                  "#{ENV["GITHUB_MILESTONES_URL"]}/issues/#{options[:id]}?github_token=#{ENV['GITHUB_PERSONAL_ACCESS_TOKEN']}"
                else
                  label = ["user story", options[:project], options[:stakeholder]].compact
            Severity: Minor
            Found in app/models/user_story.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method decode_token has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                def decode_token(token)
                  public_key = OpenSSL::PKey::RSA.new(ENV['JWT_PUBLIC_KEY'].to_s.gsub('\n', "\n"))
                  payload = (JWT.decode token, public_key, true, { :algorithm => 'RS256' }).first
            
                  # check whether token has expired
            Severity: Minor
            Found in app/models/concerns/authenticable.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method parse_data has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              def self.parse_data(result, options={})
                return nil if result.body.blank? || result.body['errors']
            
                if options[:id].present?
                  item = result.body.fetch("data", {})
            Severity: Minor
            Found in app/models/data_center.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method parse_data has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              def self.parse_data(result, options={})
                return nil if result.body.blank? || result.body['errors']
            
                if options[:id].present?
                  item = result.body.fetch("data", {})
            Severity: Minor
            Found in app/models/member.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method parse_data has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              def self.parse_data(result, options={})
                return nil if result.blank? || result['errors']
            
                if options[:id].present?
                  item = result.body.fetch("data", {})
            Severity: Minor
            Found in app/models/user_story.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                    return { data: [], meta: [] } if related_doi_identifiers.blank?
            Severity: Major
            Found in app/models/work.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return { data: [], meta: [] } if items.blank?
              Severity: Major
              Found in app/models/work.rb - About 30 mins to fix

                Method doi_as_url has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    def doi_as_url(doi)
                      doi = validate_doi(doi)
                      return nil unless doi.present?
                      # use test handle server unless production environment
                      doi_resolver = Rails.env.production? ? "https://doi.org/" : "https://handle.test.datacite.org/"
                Severity: Minor
                Found in app/models/concerns/identifiable.rb - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language