Sign upLogin

dataplug-io/dataplug-sql

View on GitHub
Star

Showing 19 of 19 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if (this._options.postprocessor) {
      const postprocessors = _.isArray(this._options.postprocessor)
        ? this._options.postprocessor
        : [this._options.postprocessor]
      _.forEach(postprocessors, (postprocessor) => {
Severity: Major
Found in lib/sqlSerializer.js and 1 other location - About 5 hrs to fix
lib/sqlSerializer.js on lines 99..111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 139.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if (this._options.preprocessor) {
      const preprocessors = _.isArray(this._options.preprocessor)
        ? this._options.preprocessor
        : [this._options.preprocessor]
      _.forEach(preprocessors, (preprocessor) => {
Severity: Major
Found in lib/sqlSerializer.js and 1 other location - About 5 hrs to fix
lib/sqlSerializer.js on lines 138..150

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 139.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function generateSqlSchema has 83 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function generateSqlSchema (dbDialect, metadata, prefix = undefined) {
  check.assert.nonEmptyString(dbDialect)
  check.assert.object(metadata)
  check.assert.maybe.string(prefix)
Severity: Major
Found in lib/generateSqlSchema.js - About 3 hrs to fix

    Function serializeObject has 53 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      serializeObject (object, tableName, metadata, queries = undefined) {
    check.assert.object(object)
    check.assert.nonEmptyString(tableName)
    check.assert.object(metadata)
    check.assert.object(metadata.fields)
    Severity: Major
    Found in lib/sqlSerializer.js - About 2 hrs to fix

      Function _doWrite has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        _doWrite (queries, callback) {
    if (this._singleTransaction && !this._singleTransactionOpened) {
      this._dbClient
        .query('BEGIN')
        .then(() => {
      Severity: Minor
      Found in lib/sqlStreamWriter.js - About 1 hr to fix

        Function serializeValue has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          serializeValue (type, value) {
    check.assert.string(type)

    if (value === null || value === undefined) {
      return 'NULL'
        Severity: Minor
        Found in lib/sqlSerializer.js - About 1 hr to fix

          Function resolveType has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

            static resolveType (type) {
    check.assert.nonEmptyString(type)

    let dbType
    const itemType = type.replace(/(\[\d*\])+/g, '')
          Severity: Minor
          Found in lib/sqlSerializer.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function serializeValue has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

            serializeValue (type, value) {
    check.assert.string(type)

    if (value === null || value === undefined) {
      return 'NULL'
          Severity: Minor
          Found in lib/sqlSerializer.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function constructor has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            constructor (dbDialect, collectionPrefix, metadata = undefined, options = undefined) {
    check.assert.nonEmptyString(dbDialect)
    check.assert.string(collectionPrefix)
    check.assert.maybe.object(metadata)
    check.assert.maybe.object(options)
          Severity: Minor
          Found in lib/sqlSerializerStream.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                if (_.isString(this._epilogue)) {
      throw new Error(`'${this._epilogue}' is not a supported epilogue`)
    } else if (_.isPlainObject(this._epilogue)) {
      const data = this._epilogue
      this._epilogue = (serializer, tableName, metadata, queries) => {
            Severity: Major
            Found in lib/sqlSerializerStream.js and 1 other location - About 1 hr to fix
            lib/sqlSerializerStream.js on lines 42..53

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 66.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                if (_.isString(this._prologue)) {
      if (this._prologue === 'truncate') {
        this._prologue = SqlSerializerStream.truncate
      } else {
        throw new Error(`'${this._prologue}' is not a supported prologue`)
            Severity: Major
            Found in lib/sqlSerializerStream.js and 1 other location - About 1 hr to fix
            lib/sqlSerializerStream.js on lines 58..65

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 66.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function _transform has 35 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              _transform (chunk, encoding, callback) {
    try {
      let queries = []

      logger.log('verbose', 'SqlSerializerStream serializing data...')
            Severity: Minor
            Found in lib/sqlSerializerStream.js - About 1 hr to fix

              Function resolveType has 31 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                static resolveType (type) {
    check.assert.nonEmptyString(type)

    let dbType
    const itemType = type.replace(/(\[\d*\])+/g, '')
              Severity: Minor
              Found in lib/sqlSerializer.js - About 1 hr to fix

                Function serializeData has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  serializeData (data, prefix = undefined, metadata = undefined, queries = undefined) {
    check.assert.object(data)
    check.assert.maybe.string(prefix)
    check.assert.maybe.object(metadata)
    check.assert.maybe.array.of.string(queries)
                Severity: Minor
                Found in lib/sqlSerializer.js - About 1 hr to fix

                  Function constructor has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                    constructor (dbDialect, collectionPrefix, metadata = undefined, options = undefined) {
    check.assert.nonEmptyString(dbDialect)
    check.assert.string(collectionPrefix)
    check.assert.maybe.object(metadata)
    check.assert.maybe.object(options)
                  Severity: Minor
                  Found in lib/sqlSerializerStream.js - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function serializeObject has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                    serializeObject (object, tableName, metadata, queries = undefined) {
    check.assert.object(object)
    check.assert.nonEmptyString(tableName)
    check.assert.object(metadata)
    check.assert.object(metadata.fields)
                  Severity: Minor
                  Found in lib/sqlSerializer.js - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function _resolveProcessor has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                    _resolveProcessor (processor) {
    if (_.isFunction(processor)) {
      return processor
    } else if (_.isString(processor)) {
      processor = _.camelCase(processor)
                  Severity: Minor
                  Found in lib/sqlSerializer.js - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function _transform has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                    _transform (chunk, encoding, callback) {
    try {
      let queries = []

      logger.log('verbose', 'SqlSerializerStream serializing data...')
                  Severity: Minor
                  Found in lib/sqlSerializerStream.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function _flush has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                    _flush (callback) {
    try {
      let queries = []

      if (this._prologue && this._epilogue) {
                  Severity: Minor
                  Found in lib/sqlSerializerStream.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language