Sign upLogin

dave-shawley/divak-tornado

View on GitHub
Star

Showing 2 of 9 total issues

Function initialize_logging has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

def initialize_logging():
    """
    Ensure that LogRecords have a divak_request_id defined.

    This is called during initialization to ensure that
Severity: Minor
Found in divak/internals.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                    if not _has_divak_filter(handler.filters):
                        handler.addFilter(log_filter)
                    known_handlers.add(handler)
Severity: Major
Found in divak/internals.py - About 45 mins to fix
    Severity
    Category
    Status
    Source
    Language