Showing 40 of 40 total issues
Method findOffsets
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
def self.findOffsets(timezones, toTime, fromTime, types = nil)
toTime = Time.now unless toTime
types = types.to_a unless types
types = [:daylight, :standard] if types.empty?
allOffsets = Set.new
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method parseMetazones
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.parseMetazones(metazoneList, offsets, locales)
metazones = {}
metazoneList.each do |lcid, data|
locale = locales[lcid]
if locale.nil?
Method getTimezones
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def self.getTimezones(name, toTime = nil, fromTime = nil, regions = @@Regions, locales = @@Locales, type = nil, all = true, modules = @@Modules)
timezones = SortedSet.new
modules = AllModules if modules.nil? or modules.empty?
timezones += Abbreviation::getTimezones(name, toTime, fromTime, regions, type) if modules.include?(:Abbreviations)
return timezones.to_a if not all and not timezones.empty?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getOffsets
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def self.getOffsets(name, toTime = nil, fromTime = nil, regions = @@Regions, locales = @@Locales, type = nil, all = true, modules = @@Modules)
offsets = SortedSet.new
modules = AllModules if modules.nil? or modules.empty?
offsets += Abbreviation::getOffsets(name, toTime, fromTime, regions, type) if modules.include?(:Abbreviations)
return offsets.to_a if not all and not offsets.empty?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getOffsets
has 8 arguments (exceeds 4 allowed). Consider refactoring. Open
def self.getOffsets(name, toTime = nil, fromTime = nil, regions = @@Regions, locales = @@Locales, type = nil, all = true, modules = @@Modules)
Method getTimezones
has 8 arguments (exceeds 4 allowed). Consider refactoring. Open
def self.getTimezones(name, toTime = nil, fromTime = nil, regions = @@Regions, locales = @@Locales, type = nil, all = true, modules = @@Modules)
Method isValid?
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def self.isValid?(name, locales = @@Locales, modules = @@Modules)
valid = false
modules = AllModules if modules.nil? or modules.empty?
valid = Abbreviation::isValid?(name) if modules.include?(:Abbreviations)
return valid if valid
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getOffsets
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def self.getOffsets(name, toTime = nil, fromTime = nil, locales = nil, types = nil)
Method getTimezones
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def self.getTimezones(timezone, toTime = nil, fromTime = nil, locales = nil, regions = nil)
Method getOffsets
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def self.getOffsets(abbreviation, toTime = nil, fromTime = nil, regions = nil, type = nil)
Method getMetazones
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def self.getMetazones(timezone, toTime = nil, fromTime = nil, locales = nil, regions = nil)
Method getOffsets
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def self.getOffsets(timezone, toTime = nil, fromTime = nil, locales = nil, regions = nil)
Method getTimezones
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def self.getTimezones(abbreviation, toTime = nil, fromTime = nil, regions = nil, type = nil)
Method getTimezoneCountries
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def self.getTimezoneCountries
unless @@TimezoneCountries
@@TimezoneCountries = {}
::TZInfo::Country.all.each do |countryData|
countryData.zone_identifiers.each do |timezone|
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method correctMUIOffsetNames
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def self.correctMUIOffsetNames(offsets, metazoneList, locales)
enUS = locales.key('en-US')
baseMetazone = metazoneList[enUS]
offsets.each do |id, data|
actualMetazone = nil
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Identical blocks of code found in 2 locations. Consider refactoring. Open
if type == 'generic'
self.updateHash(timezones[locale][name], 'Types', 'standard')
self.updateHash(timezones[locale][name], 'Types', 'daylight')
else
self.updateHash(timezones[locale][name], 'Types', type)
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 32.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
if type == 'generic'
self.updateHash(timezones[locale][name], 'Types', 'standard')
self.updateHash(timezones[locale][name], 'Types', 'daylight')
else
self.updateHash(timezones[locale][name], 'Types', type)
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 32.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Method getFilteredData
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def getFilteredData(dataType)
params = []
column = nil
joins = ''
regionJoins = ''
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method convertTypes
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def self.convertTypes(rawTypes)
types = Set.new
rawTypes.each do |t|
types << :standard unless (t.to_i & TIMEZONE_TYPE_STANDARD).zero?
types << :daylight unless (t.to_i & TIMEZONE_TYPE_DAYLIGHT).zero?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method set
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def set(locales = nil, regions = nil, types = nil)
@Locales = locales unless locales.nil?
@Regions = regions unless regions.nil?
@Types = types unless types.nil?
self
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"