Sign upLogin

davispuh/TimezoneParser

View on GitHub
Star
lib/timezone_parser/abbreviation.rb

Summary

Maintainability
C
1 day
Test Coverage

Method getFilteredData has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

        def getFilteredData(dataType)
            types = nil
            types = [@Type] if @Type

            params = [@Abbreviation.downcase]
Severity: Minor
Found in lib/timezone_parser/abbreviation.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getFilteredData has 96 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def getFilteredData(dataType)
            types = nil
            types = [@Type] if @Type

            params = [@Abbreviation.downcase]
Severity: Major
Found in lib/timezone_parser/abbreviation.rb - About 3 hrs to fix

    Method getOffsets has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            def self.getOffsets(abbreviation, toTime = nil, fromTime = nil, regions = nil, type = nil)
    Severity: Minor
    Found in lib/timezone_parser/abbreviation.rb - About 35 mins to fix

      Method getTimezones has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              def self.getTimezones(abbreviation, toTime = nil, fromTime = nil, regions = nil, type = nil)
      Severity: Minor
      Found in lib/timezone_parser/abbreviation.rb - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status