Sign upLogin

dblock/slack-gamebot

View on GitHub
Star

Showing 68 of 126 total issues

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  module Presenters
    module UserRanksPresenter
      include Roar::JSON::HAL
      include Roar::Hypermedia
      include Grape::Roar::Representer
Severity: Minor
Found in slack-gamebot/api/presenters/user_ranks_presenter.rb and 6 other locations - About 15 mins to fix
slack-gamebot/api/presenters/challenges_presenter.rb on lines 2..10
slack-gamebot/api/presenters/games_presenter.rb on lines 2..10
slack-gamebot/api/presenters/matches_presenter.rb on lines 2..10
slack-gamebot/api/presenters/seasons_presenter.rb on lines 2..10
slack-gamebot/api/presenters/teams_presenter.rb on lines 2..10
slack-gamebot/api/presenters/users_presenter.rb on lines 2..10

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  module Presenters
    module GamesPresenter
      include Roar::JSON::HAL
      include Roar::Hypermedia
      include Grape::Roar::Representer
Severity: Minor
Found in slack-gamebot/api/presenters/games_presenter.rb and 6 other locations - About 15 mins to fix
slack-gamebot/api/presenters/challenges_presenter.rb on lines 2..10
slack-gamebot/api/presenters/matches_presenter.rb on lines 2..10
slack-gamebot/api/presenters/seasons_presenter.rb on lines 2..10
slack-gamebot/api/presenters/teams_presenter.rb on lines 2..10
slack-gamebot/api/presenters/user_ranks_presenter.rb on lines 2..10
slack-gamebot/api/presenters/users_presenter.rb on lines 2..10

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  module Presenters
    module ChallengesPresenter
      include Roar::JSON::HAL
      include Roar::Hypermedia
      include Grape::Roar::Representer
Severity: Minor
Found in slack-gamebot/api/presenters/challenges_presenter.rb and 6 other locations - About 15 mins to fix
slack-gamebot/api/presenters/games_presenter.rb on lines 2..10
slack-gamebot/api/presenters/matches_presenter.rb on lines 2..10
slack-gamebot/api/presenters/seasons_presenter.rb on lines 2..10
slack-gamebot/api/presenters/teams_presenter.rb on lines 2..10
slack-gamebot/api/presenters/user_ranks_presenter.rb on lines 2..10
slack-gamebot/api/presenters/users_presenter.rb on lines 2..10

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  module Presenters
    module TeamsPresenter
      include Roar::JSON::HAL
      include Roar::Hypermedia
      include Grape::Roar::Representer
Severity: Minor
Found in slack-gamebot/api/presenters/teams_presenter.rb and 6 other locations - About 15 mins to fix
slack-gamebot/api/presenters/challenges_presenter.rb on lines 2..10
slack-gamebot/api/presenters/games_presenter.rb on lines 2..10
slack-gamebot/api/presenters/matches_presenter.rb on lines 2..10
slack-gamebot/api/presenters/seasons_presenter.rb on lines 2..10
slack-gamebot/api/presenters/user_ranks_presenter.rb on lines 2..10
slack-gamebot/api/presenters/users_presenter.rb on lines 2..10

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

      link :challengers do |opts|
        request = Grape::Request.new(opts[:env])
        represented.challengers.map do |challenger|
          "#{request.base_url}/api/users/#{challenger.id}"
Severity: Minor
Found in slack-gamebot/api/presenters/challenge_presenter.rb and 3 other locations - About 15 mins to fix
slack-gamebot/api/presenters/challenge_presenter.rb on lines 36..39
slack-gamebot/api/presenters/match_presenter.rb on lines 24..27
slack-gamebot/api/presenters/match_presenter.rb on lines 31..34

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

      link :losers do |opts|
        request = Grape::Request.new(opts[:env])
        represented.losers.map do |user|
          "#{request.base_url}/api/users/#{user.id}"
Severity: Minor
Found in slack-gamebot/api/presenters/match_presenter.rb and 3 other locations - About 15 mins to fix
slack-gamebot/api/presenters/challenge_presenter.rb on lines 29..32
slack-gamebot/api/presenters/challenge_presenter.rb on lines 36..39
slack-gamebot/api/presenters/match_presenter.rb on lines 24..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

      link :challenged do |opts|
        request = Grape::Request.new(opts[:env])
        represented.challenged.map do |challenged|
          "#{request.base_url}/api/users/#{challenged.id}"
Severity: Minor
Found in slack-gamebot/api/presenters/challenge_presenter.rb and 3 other locations - About 15 mins to fix
slack-gamebot/api/presenters/challenge_presenter.rb on lines 29..32
slack-gamebot/api/presenters/match_presenter.rb on lines 24..27
slack-gamebot/api/presenters/match_presenter.rb on lines 31..34

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

      link :winners do |opts|
        request = Grape::Request.new(opts[:env])
        represented.winners.map do |user|
          "#{request.base_url}/api/users/#{user.id}"
Severity: Minor
Found in slack-gamebot/api/presenters/match_presenter.rb and 3 other locations - About 15 mins to fix
slack-gamebot/api/presenters/challenge_presenter.rb on lines 29..32
slack-gamebot/api/presenters/challenge_presenter.rb on lines 36..39
slack-gamebot/api/presenters/match_presenter.rb on lines 31..34

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language