deep-web-solutions/wordpress-framework-woocommerce

View on GitHub

Showing 5 of 8 total issues

WC_AbstractValidatedProductSettingsGroupFunctionality has 29 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class WC_AbstractValidatedProductSettingsGroupFunctionality extends AbstractPluginFunctionality implements ValidationServiceAwareInterface {
    // region TRAITS

    use InitializeValidationServiceTrait , ValidationServiceAwareTrait {
        ValidationServiceAwareTrait::get_default_value as protected get_default_value_trait;

    Method output_tab_panel has 66 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function output_tab_panel(): void {
            global $thepostid;
    
            if ( true !== $this->is_supported_product( $thepostid ) ) {
                return;

      Function output_tab_panel has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          public function output_tab_panel(): void {
              global $thepostid;
      
              if ( true !== $this->is_supported_product( $thepostid ) ) {
                  return;

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method register_options_group has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function register_options_group( string $group_id, $group_title, $fields, string $page, array $params ): bool {
              if ( \did_action( "woocommerce_sections_$page" ) ) {
                  return false;
              }
      
      
      Severity: Minor
      Found in src/includes/Settings/WC_SettingsAdapter.php - About 1 hr to fix

        Function filter_default_wc_metadata has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function filter_default_wc_metadata( array $meta_data, object $object ): array {
                if ( \is_a( $object, \WC_Product::class ) && true === $this->is_supported_product( $object->get_id() ) ) {
                    $existing_meta_keys = \array_flip( \array_column( $meta_data, 'meta_key' ) );
        
                    foreach ( \array_keys( $this->get_group_fields() ) as $field_id ) {

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language