deparkes/OOMMFTools

View on GitHub

Showing 74 of 74 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    def makeChomp(self, evt):
        """Open odtchomp window.
        """
        if not self.odtchomp:
            self.odtchomp = odtchomp.MainFrame(self)
Severity: Minor
Found in oommftools/user_interfaces/gui/main.py and 2 other locations - About 35 mins to fix
oommftools/user_interfaces/gui/main.py on lines 76..80
oommftools/user_interfaces/gui/main.py on lines 82..86

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    def makeDecode(self, evt):
        """Open oommfdecode window
        """
        if not self.oommfdecode:
            self.oommfdecode = oommfdecode.MainFrame(self)
Severity: Minor
Found in oommftools/user_interfaces/gui/main.py and 2 other locations - About 35 mins to fix
oommftools/user_interfaces/gui/main.py on lines 82..86
oommftools/user_interfaces/gui/main.py on lines 88..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function runSubProcess has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

def runSubProcess(command, stdinRedirect, mode, checkPath):
    if mode == "basic":
        os.system(command)
    elif mode == 'advanced':
        pipe = subprocess.Popen(command, **getSubProcessArgs(command,
Severity: Minor
Found in oommftools/core/oommfconvert.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    confpath, cleanconfig = resolveConfiguration(targetList, 
                                                 config_parent['magnifierSpin'],
                                                 config_parent['autoMaxVectors'],
                                                 config_parent['config'])
Severity: Minor
Found in oommftools/core/oommfconvert.py and 1 other location - About 35 mins to fix
oommftools/core/oommfconvert.py on lines 206..209

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

            return 1
Severity: Major
Found in oommftools/user_interfaces/gui/oommfconvert.py - About 30 mins to fix

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

            sizer.Add(self.importButton, 0, wx.ALIGN_CENTER | wx.TOP | wx.BOTTOM, 10)
    Severity: Major
    Found in oommftools/user_interfaces/gui/odtchomp.py and 5 other locations - About 30 mins to fix
    oommftools/user_interfaces/gui/odtchomp.py on lines 125..125
    oommftools/user_interfaces/gui/odtchomp.py on lines 171..171
    oommftools/user_interfaces/gui/odtchomp.py on lines 203..203
    oommftools/user_interfaces/gui/oommfconvert.py on lines 158..158
    oommftools/user_interfaces/gui/oommfconvert.py on lines 182..182

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 32.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

            llbsizer.Add(self.leftbox, 1, wx.ALIGN_CENTER | wx.EXPAND | wx.TOP, 10)
    Severity: Major
    Found in oommftools/user_interfaces/gui/odtchomp.py and 5 other locations - About 30 mins to fix
    oommftools/user_interfaces/gui/odtchomp.py on lines 108..108
    oommftools/user_interfaces/gui/odtchomp.py on lines 171..171
    oommftools/user_interfaces/gui/odtchomp.py on lines 203..203
    oommftools/user_interfaces/gui/oommfconvert.py on lines 158..158
    oommftools/user_interfaces/gui/oommfconvert.py on lines 182..182

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 32.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

            imsizer.Add(self.doImages, 0, wx.ALIGN_CENTER | wx.ALIGN_CENTER_VERTICAL | wx.RIGHT, 30)
    Severity: Major
    Found in oommftools/user_interfaces/gui/oommfconvert.py and 5 other locations - About 30 mins to fix
    oommftools/user_interfaces/gui/odtchomp.py on lines 108..108
    oommftools/user_interfaces/gui/odtchomp.py on lines 125..125
    oommftools/user_interfaces/gui/odtchomp.py on lines 171..171
    oommftools/user_interfaces/gui/odtchomp.py on lines 203..203
    oommftools/user_interfaces/gui/oommfconvert.py on lines 158..158

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 32.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

            sizer.Add(self.ConfPathLabel, 0, wx.ALIGN_CENTER | wx.TOP | wx.BOTTOM, 10)
    Severity: Major
    Found in oommftools/user_interfaces/gui/oommfconvert.py and 5 other locations - About 30 mins to fix
    oommftools/user_interfaces/gui/odtchomp.py on lines 108..108
    oommftools/user_interfaces/gui/odtchomp.py on lines 125..125
    oommftools/user_interfaces/gui/odtchomp.py on lines 171..171
    oommftools/user_interfaces/gui/odtchomp.py on lines 203..203
    oommftools/user_interfaces/gui/oommfconvert.py on lines 182..182

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 32.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

            rlbsizer.Add(self.rightbox, 1, wx.ALIGN_CENTER | wx.EXPAND | wx.TOP, 10)
    Severity: Major
    Found in oommftools/user_interfaces/gui/odtchomp.py and 5 other locations - About 30 mins to fix
    oommftools/user_interfaces/gui/odtchomp.py on lines 108..108
    oommftools/user_interfaces/gui/odtchomp.py on lines 125..125
    oommftools/user_interfaces/gui/odtchomp.py on lines 203..203
    oommftools/user_interfaces/gui/oommfconvert.py on lines 158..158
    oommftools/user_interfaces/gui/oommfconvert.py on lines 182..182

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 32.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

            sizer.Add(self.exportButton, 0, wx.ALIGN_CENTER | wx.TOP | wx.BOTTOM, 10)
    Severity: Major
    Found in oommftools/user_interfaces/gui/odtchomp.py and 5 other locations - About 30 mins to fix
    oommftools/user_interfaces/gui/odtchomp.py on lines 108..108
    oommftools/user_interfaces/gui/odtchomp.py on lines 125..125
    oommftools/user_interfaces/gui/odtchomp.py on lines 171..171
    oommftools/user_interfaces/gui/oommfconvert.py on lines 158..158
    oommftools/user_interfaces/gui/oommfconvert.py on lines 182..182

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 32.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function _textDecode has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def _textDecode(filehandle, targetarray, headers, extraCaptures):
        """
        """
        valm = headers.get("valuemultiplier", 1)
        for k in range(int(headers["znodes"])):
    Severity: Minor
    Found in oommftools/core/oommfdecode.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function groupUnpack has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def groupUnpack(self, targetlist, progdialog=None):
            """
            """
            try:
                (decodedArrays, headers, extraData) = oommfdecode.groupUnpack(targetlist)
    Severity: Minor
    Found in oommftools/user_interfaces/gui/oommfdecode.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getOOMMFPath has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def getOOMMFPath(pathFileToCheck):
        # Check if we have a saved OOMMF path to use as config data
        if os.path.exists(pathFileToCheck):
            f = open(pathFileToCheck)
            lines = f.readlines()
    Severity: Minor
    Found in oommftools/core/oommfconvert.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language