Sign upLogin

deparkes/OOMMFTools

View on GitHub
Star
oommftools/core/oommfconvert.py

Summary

Maintainability
D
1 day
Test Coverage

Function replaceConfigLines has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

def replaceConfigLines(oldconflines, newMax, percentMagnitude, checkVectors):
    newconf = []
    for line in oldconflines:
        # Only one data point for line. Let's deal with our cases.
        if "misc,datascale" in line and checkVectors:
Severity: Minor
Found in oommftools/core/oommfconvert.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function doMovies has 9 arguments (exceeds 4 allowed). Consider refactoring.
Open

def doMovies(targetList, stdinRedirect, config_parent, movieCodec, movieFPS, tclCall, OOMMFPath, doImages, codecs):
Severity: Major
Found in oommftools/core/oommfconvert.py - About 1 hr to fix

    Function createTempImagesForMovie has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def createTempImagesForMovie(targetList, moviepath, framedupes, maxdigits, tclCall, OOMMFPath, confpath, stdinRedirect, removeImages=False):
    Severity: Major
    Found in oommftools/core/oommfconvert.py - About 1 hr to fix

      Function makeMovieFromImages has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def makeMovieFromImages(moviePath, pathTo, maxDigits, movieCodec, stdinRedirect, codecs, mode='advanced'):
      Severity: Major
      Found in oommftools/core/oommfconvert.py - About 50 mins to fix

        Function convertOmfToImage has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def convertOmfToImage(omf, tclCall, oommfPath, confpath, stdinRedirect, mode='advanced'):
        Severity: Minor
        Found in oommftools/core/oommfconvert.py - About 45 mins to fix

          Function doImages has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def doImages(targetList, stdinRedirect, config_parent, tclCall, OOMMFPath):
          Severity: Minor
          Found in oommftools/core/oommfconvert.py - About 35 mins to fix

            Function runSubProcess has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            def runSubProcess(command, stdinRedirect, mode, checkPath):
    if mode == "basic":
        os.system(command)
    elif mode == 'advanced':
        pipe = subprocess.Popen(command, **getSubProcessArgs(command,
            Severity: Minor
            Found in oommftools/core/oommfconvert.py - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getOOMMFPath has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            def getOOMMFPath(pathFileToCheck):
    # Check if we have a saved OOMMF path to use as config data
    if os.path.exists(pathFileToCheck):
        f = open(pathFileToCheck)
        lines = f.readlines()
            Severity: Minor
            Found in oommftools/core/oommfconvert.py - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        elif "misc,height" in line:
                newval = int(re.findall(r"[0-9]+", line)
                             [0]) * percentMagnitude / 100.0
                newconf.append("    misc,height " + str(newval) + "\n")
            Severity: Major
            Found in oommftools/core/oommfconvert.py and 1 other location - About 2 hrs to fix
            oommftools/core/oommfconvert.py on lines 73..76

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 60.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        elif "misc,width" in line:
                newval = int(re.findall(r"[0-9]+", line)
                             [0]) * percentMagnitude / 100.0
                newconf.append("    misc,width " + str(newval) + "\n")
            Severity: Major
            Found in oommftools/core/oommfconvert.py and 1 other location - About 2 hrs to fix
            oommftools/core/oommfconvert.py on lines 69..72

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 60.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                confpath, cleanconfig = resolveConfiguration(targetList, 
                                                 config_parent['magnifierSpin'],
                                                 config_parent['autoMaxVectors'],
                                                 config_parent['config'])
            Severity: Minor
            Found in oommftools/core/oommfconvert.py and 1 other location - About 35 mins to fix
            oommftools/core/oommfconvert.py on lines 191..194

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 33.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                confpath, cleanconfig = resolveConfiguration(targetList, 
                                                 config_parent['magnifierSpin'],
                                                 config_parent['autoMaxVectors'],
                                                 config_parent['config'])
            Severity: Minor
            Found in oommftools/core/oommfconvert.py and 1 other location - About 35 mins to fix
            oommftools/core/oommfconvert.py on lines 206..209

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 33.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status