Sign upLogin

derwentx/Xero-Map-Generator

View on GitHub
Star
xero_map_gen/contain.py

Summary

Maintainability
B
4 hrs
Test Coverage

File contain.py has 259 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#!/usr/bin/env python2
"""Container classes and utilities for containing data."""

import csv
import heapq
Severity: Minor
Found in xero_map_gen/contain.py - About 2 hrs to fix

    Function _primary_property has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def _primary_property(
            self, properties, type_key, type_priority, fn_empty, default=None):
        """ Abstract main_address and main_phone. """
        if not properties:
            return default
    Severity: Minor
    Found in xero_map_gen/contain.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _primary_property has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def _primary_property(
    Severity: Minor
    Found in xero_map_gen/contain.py - About 35 mins to fix

      Function dump_items_csv has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def dump_items_csv(cls, items, dump_path='items.csv', names=None, flatten_attr=None):
        try:
            with open(dump_path, 'w'):
                pass
        except IOError as exc:
      Severity: Minor
      Found in xero_map_gen/contain.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Either remove or fill this block of code.
      Open

                      pass
      Severity: Major
      Found in xero_map_gen/contain.py by sonar-python

      Most of the time a block of code is empty when a piece of code is really missing. So such empty block must be either filled or removed.

      Noncompliant Code Example

      for i in range(3):
    pass

      Exceptions

      When a block contains a comment, this block is not considered to be empty.

      There are no issues that match your filters.

      Category
      Status