derwentx/Xero-Map-Generator

View on GitHub
xero_map_gen/transport.py

Summary

Maintainability
A
1 hr
Test Coverage
B
82%

Function get_contacts_by_ids has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def get_contacts_by_ids(self, contact_ids, limit=None, chunk_size=20):
        # TODO: local caching and check modified time
        limit = limit or None
        total = len(contact_ids)
        if limit is not None:
Severity: Minor
Found in xero_map_gen/transport.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _get_contact_ids_in_group_ids has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def _get_contact_ids_in_group_ids(
            self, contact_group_ids=None, limit=None):
        contact_ids = set()
        for contact_group_id in contact_group_ids:
            group_data = self.rate_limit_retry_query(
Severity: Minor
Found in xero_map_gen/transport.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status