derwentx/darp

View on GitHub

Showing 4 of 4 total issues

Function generate_mac_alerts has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

def generate_mac_alerts(dbwrapper, oldDevices, newDevices, stamp):
    """ Generate alerts based on new and old devices detected. """
    alerts = {}

    # print "newDevices", newDevices
Severity: Minor
Found in darp/core.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function print_alerts has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

def print_alerts(alerts):
    """ Print a given alerts dictionary. """
    if not alerts:
        print("no alerts")
        return
Severity: Minor
Found in darp/core.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function process_args has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def process_args(args, arp_scan_settings):
    if not args.db:
        return
    db_path = args.db

Severity: Minor
Found in darp/core.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parse has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def parse(cls, out):
        """ Parse the output of running arp-scan, return dict. """
        results = {}
        for line in out.split('\n'):
            if re.match(cls.re_interface, line):
Severity: Minor
Found in darp/arp_scan.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language