Sign upLogin

derwentx/feature-hunter

View on GitHub
Star

Showing 3 of 5 total issues

Function get_record_fields has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def get_record_fields(self, record_selector):
        record_fields = {}
        for field_name, field_spec in self.field_specs.items():
            # print "processing field %s with fieldspec %s" % (field_name, str(field_spec))
            # print "respons being parsed: %s" % (record_selector.extract())
Severity: Minor
Found in feature_hunter/crawler.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self, record_spec, field_specs, start_urls, *args, **kwargs):
Severity: Minor
Found in feature_hunter/crawler.py - About 35 mins to fix

    Function get_settings has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    def get_settings(args):
    if not args:
        return
    db_path = args.db
    scrapy_settings = {}
    Severity: Minor
    Found in feature_hunter/core.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language