Sign upLogin

dev-coop/meancoach

View on GitHub
Star
meancoach_project/apps/metrics/views/measurement.py

Summary

Maintainability
B
4 hrs
Test Coverage

Function measurement_input has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

def measurement_input(request):
    date_string = request.GET.get('date', None)
    if date_string is not None and date_string is not '':
        date = parser.parse(date_string).replace(tzinfo=None)
    else:
Severity: Minor
Found in meancoach_project/apps/metrics/views/measurement.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                    if m.pk == int(metric_pk):
                        m.notes = value.get('notes', None)
                        m.measurement = value['measurement']
                        m.save()
Severity: Major
Found in meancoach_project/apps/metrics/views/measurement.py - About 45 mins to fix

    There are no issues that match your filters.

    Category
    Status