dgk/django-business-logic

View on GitHub
business_logic/blockly/parse.py

Summary

Maintainability
B
5 hrs
Test Coverage

BlocklyXmlParser has 35 functions (exceeds 20 allowed). Consider refactoring.
Open

class BlocklyXmlParser(object):

    def parse(self, xml_str):
        """
        :param xml_str: blockly native XML string
Severity: Minor
Found in business_logic/blockly/parse.py - About 4 hrs to fix

Function _process_next has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def _process_next(self, node):
        children = []
        _node = node

        while True:
Severity: Minor
Found in business_logic/blockly/parse.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _visit_children has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def _visit_children(self, node, data, children=None):
        if 'children' not in data:
            data['children'] = []
        for child in node.getchildren() if children is None else children:
            child_data = self.visit(child)
Severity: Minor
Found in business_logic/blockly/parse.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status