discourse/discourse

View on GitHub
app/models/topic_link_click.rb

Summary

Maintainability
C
1 day
Test Coverage

Method create_from has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
Open

  def self.create_from(args = {})
    url = args[:url][0...TopicLink.max_url_length]
    return nil if url.blank?

    uri = begin
Severity: Minor
Found in app/models/topic_link_click.rb - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create_from has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.create_from(args = {})
    url = args[:url][0...TopicLink.max_url_length]
    return nil if url.blank?

    uri = begin
Severity: Major
Found in app/models/topic_link_click.rb - About 2 hrs to fix

    Avoid too many return statements within this method.
    Open

          return url if WHITELISTED_REDIRECT_HOSTNAMES.include?(uri.hostname) || is_cdn_link
    Severity: Major
    Found in app/models/topic_link_click.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

            return nil
      Severity: Major
      Found in app/models/topic_link_click.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

            return url if args[:user_id] && link.user_id == args[:user_id]
        Severity: Major
        Found in app/models/topic_link_click.rb - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status