discourse/discourse

View on GitHub
app/serializers/user_serializer.rb

Summary

Maintainability
D
2 days
Test Coverage

Class UserSerializer has 81 methods (exceeds 20 allowed). Consider refactoring.
Open

class UserSerializer < BasicUserSerializer

  attr_accessor :omit_stats,
                :topic_post_count

Severity: Major
Found in app/serializers/user_serializer.rb - About 1 day to fix

    File user_serializer.rb has 387 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class UserSerializer < BasicUserSerializer
    
      attr_accessor :omit_stats,
                    :topic_post_count
    
    
    Severity: Minor
    Found in app/serializers/user_serializer.rb - About 5 hrs to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        private_attributes :locale,
                           :muted_category_ids,
                           :watched_tags,
                           :watching_first_post_tags,
                           :tracked_tags,
      Severity: Minor
      Found in app/serializers/user_serializer.rb and 2 other locations - About 15 mins to fix
      app/models/report.rb on lines 10..16
      app/serializers/topic_view_serializer.rb on lines 21..46

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status