discourse/discourse

View on GitHub

Showing 1,271 of 1,538 total issues

Method send_notification_email has a Cognitive Complexity of 65 (exceeds 5 allowed). Consider refactoring.
Open

  def send_notification_email(opts)
    post = opts[:post]
    title = opts[:title]

    allow_reply_by_email = opts[:allow_reply_by_email]
Severity: Minor
Found in app/mailers/user_notifications.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class UserSerializer has 69 methods (exceeds 20 allowed). Consider refactoring.
Open

class UserSerializer < BasicUserSerializer

  attr_accessor :omit_stats,
                :topic_post_count

Severity: Major
Found in app/serializers/user_serializer.rb - About 1 day to fix

    Method update has a Cognitive Complexity of 63 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.update(post, polls)
          # load previous polls
          previous_polls = post.custom_fields[DiscoursePoll::POLLS_CUSTOM_FIELD] || {}
    
          # extract options
    Severity: Minor
    Found in plugins/poll/lib/polls_updater.rb - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File group.rb has 576 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require_dependency 'enum'
    
    class Group < ActiveRecord::Base
      include HasCustomFields
      include AnonCacheInvalidator
    Severity: Major
    Found in app/models/group.rb - About 1 day to fix

      Method show has a Cognitive Complexity of 62 (exceeds 5 allowed). Consider refactoring.
      Open

        def show
          if request.referer
            flash["referer"] ||= request.referer[0..255]
          end
      
      
      Severity: Minor
      Found in app/controllers/topics_controller.rb - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File track_selector_spec.rb has 570 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      require 'rails_helper'
      
      describe DiscourseNarrativeBot::TrackSelector do
        let(:user) { Fabricate(:user) }
        let(:discobot_user) { User.find(-2) }

        Method create_for has a Cognitive Complexity of 61 (exceeds 5 allowed). Consider refactoring.
        Open

          def create_for(user_id)
            if filesize <= 0
              @upload.errors.add(:base, I18n.t("upload.empty"))
              return @upload
            end
        Severity: Minor
        Found in lib/upload_creator.rb - About 1 day to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File posts_controller.rb has 549 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        require_dependency 'new_post_manager'
        require_dependency 'post_creator'
        require_dependency 'post_destroyer'
        require_dependency 'post_merger'
        require_dependency 'distributed_memoizer'
        Severity: Major
        Found in app/controllers/posts_controller.rb - About 1 day to fix

          Method send has a Cognitive Complexity of 58 (exceeds 5 allowed). Consider refactoring.
          Open

              def send
                return if SiteSetting.disable_emails == "yes" && @email_type.to_s != "admin_login"
          
                return if ActionMailer::Base::NullMail === @message
                return if ActionMailer::Base::NullMail === (@message.message rescue nil)
          Severity: Minor
          Found in lib/email/sender.rb - About 1 day to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          File application_controller.rb has 544 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          require 'current_user'
          require_dependency 'canonical_url'
          require_dependency 'discourse'
          require_dependency 'custom_renderer'
          require_dependency 'archetype'
          Severity: Major
          Found in app/controllers/application_controller.rb - About 1 day to fix

            Class ApplicationController has 62 methods (exceeds 20 allowed). Consider refactoring.
            Open

            class ApplicationController < ActionController::Base
              include CurrentUser
              include CanonicalURL::ControllerExtensions
              include JsonError
              include GlobalPath
            Severity: Major
            Found in app/controllers/application_controller.rb - About 1 day to fix

              Class Instance has 61 methods (exceeds 20 allowed). Consider refactoring.
              Open

              class Plugin::Instance
              
                attr_accessor :path, :metadata
                attr_reader :admin_route
              
              
              Severity: Major
              Found in lib/plugin/instance.rb - About 1 day to fix

                Class PostSerializer has 61 methods (exceeds 20 allowed). Consider refactoring.
                Open

                class PostSerializer < BasicPostSerializer
                
                  # To pass in additional information we might need
                  INSTANCE_VARS ||= [
                    :topic_view,
                Severity: Major
                Found in app/serializers/post_serializer.rb - About 1 day to fix

                  Method backfill has a Cognitive Complexity of 55 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def self.backfill(badge, opts = nil)
                      return unless SiteSetting.enable_badges
                      return unless badge.enabled
                      return unless badge.query.present?
                  
                  
                  Severity: Minor
                  Found in app/services/badge_granter.rb - About 1 day to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Class TopicView has 59 methods (exceeds 20 allowed). Consider refactoring.
                  Open

                  class TopicView
                  
                    attr_reader :topic, :posts, :guardian, :filtered_posts, :chunk_size, :print, :message_bus_last_id
                    attr_accessor :draft, :draft_key, :draft_sequence, :user_custom_fields, :post_custom_fields, :post_number
                  
                  
                  Severity: Major
                  Found in lib/topic_view.rb - About 1 day to fix

                    File user_notifications.rb has 517 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    require_dependency 'markdown_linker'
                    require_dependency 'email/message_builder'
                    require_dependency 'age_words'
                    require_dependency 'rtl'
                    
                    
                    Severity: Major
                    Found in app/mailers/user_notifications.rb - About 1 day to fix

                      File advanced_user_narrative_spec.rb has 516 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      require 'rails_helper'
                      
                      RSpec.describe DiscourseNarrativeBot::AdvancedUserNarrative do
                        let(:discobot_user) { User.find(-2) }
                        let(:first_post) { Fabricate(:post, user: discobot_user) }

                        Method hijack has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring.
                        Open

                          def hijack(&blk)
                            controller_class = self.class
                        
                            if hijack = request.env['rack.hijack']
                        
                        
                        Severity: Minor
                        Found in lib/hijack.rb - About 1 day to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Class Guardian has 56 methods (exceeds 20 allowed). Consider refactoring.
                        Open

                        class Guardian
                          include EnsureMagic
                          include CategoryGuardian
                          include PostGuardian
                          include TopicGuardian
                        Severity: Major
                        Found in lib/guardian.rb - About 1 day to fix

                          Method resolve has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
                          Open

                            def resolve
                              if @uri && @uri.port == 80 && FinalDestination.is_https_domain?(@uri.hostname)
                                @uri.scheme = "https"
                                @uri = URI(@uri.to_s)
                              end
                          Severity: Minor
                          Found in lib/final_destination.rb - About 7 hrs to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Severity
                          Category
                          Status
                          Source
                          Language