discourse/discourse

View on GitHub

Showing 1,294 of 1,569 total issues

Avoid too many return statements within this method.
Open

      return
Severity: Major
Found in app/controllers/static_controller.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

          return render json: failed_json, status: 422
    Severity: Major
    Found in app/controllers/users_controller.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

            return fail_with('login.incorrect_username_email_or_password')
      Severity: Major
      Found in app/controllers/users_controller.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

              return
        Severity: Major
        Found in app/controllers/static_controller.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

              return mailgun_failure unless mailgun_verify(timestamp, token, params["signature"])
          Severity: Major
          Found in app/controllers/webhooks_controller.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                      return fail_with("login.missing_user_field") if f.required?
            Severity: Major
            Found in app/controllers/users_controller.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return proxy_avatar(Discourse.store.cdn_url(optimized.url))
              Severity: Major
              Found in app/controllers/user_avatars_controller.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                      return true
                Severity: Major
                Found in app/services/spam_rule/auto_silence.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                        return
                  Severity: Major
                  Found in app/controllers/topics_controller.rb - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                        return if notifier_id && MutedUser.where(user_id: user.id, muted_user_id: notifier_id)
                    Severity: Major
                    Found in app/services/post_alerter.rb - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                          return if TopicUser.where(
                      Severity: Major
                      Found in app/services/post_alerter.rb - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                            return if existing_notification && !should_notify_previous?(user, existing_notification, opts)
                        Severity: Major
                        Found in app/services/post_alerter.rb - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                              return if post.topic.blank?
                          Severity: Major
                          Found in app/services/post_action_notifier.rb - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                return if SiteSetting.disable_edit_notifications && post_revision.user_id == Discourse::SYSTEM_USER_ID
                            Severity: Major
                            Found in app/services/post_action_notifier.rb - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                    return redirect_to cdn_path(avatar_url)
                              Severity: Major
                              Found in app/controllers/user_avatars_controller.rb - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                      return redirect_to cdn_path(avatar_url)
                                Severity: Major
                                Found in app/controllers/user_avatars_controller.rb - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                        return if GroupUser.where(
                                  Severity: Major
                                  Found in app/services/post_alerter.rb - About 30 mins to fix

                                    Avoid too many return statements within this method.
                                    Open

                                        return if user.staged? && post.topic.category&.mailinglist_mirror?
                                    Severity: Major
                                    Found in app/services/post_alerter.rb - About 30 mins to fix

                                      Avoid too many return statements within this method.
                                      Open

                                            return
                                      Severity: Major
                                      Found in app/services/badge_granter.rb - About 30 mins to fix

                                        Avoid too many return statements within this method.
                                        Open

                                              return
                                        Severity: Major
                                        Found in app/controllers/topics_controller.rb - About 30 mins to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language