discourse/discourse

View on GitHub

Showing 1,464 of 1,773 total issues

Avoid too many return statements within this method.
Open

    return true
Severity: Major
Found in lib/promotion.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

          return skip(SkippedEmailLog.reason_types[:sender_message_to_blank]) if @message.to.blank?
    Severity: Major
    Found in lib/email/sender.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

            return skip(SkippedEmailLog.reason_types[:sender_message_to_invalid]) if to_address.end_with?(".invalid")
      Severity: Major
      Found in lib/email/sender.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

            return false if stat.likes_received < SiteSetting.tl2_requires_likes_received
        Severity: Major
        Found in lib/promotion.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                    return skip(SkippedEmailLog.reason_types[:sender_text_part_body_blank])
          Severity: Major
          Found in lib/email/sender.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                  return extract_from_address_and_name(mail.from) if mail.from.is_a? String
            Severity: Major
            Found in lib/email/receiver.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                  return false if stat.days_visited < SiteSetting.tl2_requires_days_visited
              Severity: Major
              Found in lib/promotion.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                    return false if user.blank?
                Severity: Major
                Found in lib/guardian.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                        return false if group.visibility_level == Group.visibility_levels[:owners]
                  Severity: Major
                  Found in lib/guardian.rb - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                              return false
                    Severity: Major
                    Found in lib/guardian.rb - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                            return unless Guardian.new.can_see_topic?(topic)
                      Severity: Major
                      Found in lib/oneboxer.rb - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                              return resolve
                        Severity: Major
                        Found in lib/final_destination.rb - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                return false
                          Severity: Major
                          Found in lib/final_destination.rb - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                return false if groups.present?
                            Severity: Major
                            Found in lib/guardian.rb - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                  return if !post || post.hidden || !allowed_post_types.include?(post.post_type)
                              Severity: Major
                              Found in lib/oneboxer.rb - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                        return @uri
                                Severity: Major
                                Found in lib/final_destination.rb - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                          return false if object.reached_recipients_limit? && !is_staff?
                                  Severity: Major
                                  Found in lib/guardian.rb - About 30 mins to fix

                                    Avoid too many return statements within this method.
                                    Open

                                        return if topic.private_message?
                                    Severity: Major
                                    Found in lib/oneboxer.rb - About 30 mins to fix

                                      Avoid too many return statements within this method.
                                      Open

                                            return @upload unless @upload.save
                                      Severity: Major
                                      Found in lib/upload_creator.rb - About 30 mins to fix

                                        Avoid too many return statements within this method.
                                        Open

                                                return false unless SiteSetting.enable_personal_messages?
                                        Severity: Major
                                        Found in lib/guardian.rb - About 30 mins to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language