discourse/discourse

View on GitHub

Showing 1,447 of 1,447 total issues

Method voters has a Cognitive Complexity of 50 (exceeds 5 allowed). Consider refactoring.
Open

    def voters
      post_id = params.require(:post_id)
      poll_name = params.require(:poll_name)

      post = Post.find_by(id: post_id)
Severity: Minor
Found in plugins/poll/plugin.rb - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class UsersController has 54 methods (exceeds 20 allowed). Consider refactoring.
Open

class UsersController < ApplicationController

  skip_before_action :authorize_mini_profiler, only: [:avatar]

  requires_login only: [
Severity: Major
Found in app/controllers/users_controller.rb - About 7 hrs to fix

    Method build has a Cognitive Complexity of 49 (exceeds 5 allowed). Consider refactoring.
    Open

        def build
          return @wizard unless SiteSetting.wizard_enabled? && @wizard.user.try(:staff?)
    
          @wizard.append_step('locale') do |step|
            step.banner = "welcome.png"
    Severity: Minor
    Found in lib/wizard/builder.rb - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method hijack has a Cognitive Complexity of 49 (exceeds 5 allowed). Consider refactoring.
    Open

      def hijack(&blk)
        controller_class = self.class
    
        if hijack = request.env['rack.hijack']
    
    
    Severity: Minor
    Found in lib/hijack.rb - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Class TopicsController has 53 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class TopicsController < ApplicationController
      requires_login only: [
        :timings,
        :destroy_timings,
        :update,
    Severity: Major
    Found in app/controllers/topics_controller.rb - About 7 hrs to fix

      Class TopicQuery has 52 methods (exceeds 20 allowed). Consider refactoring.
      Open

      class TopicQuery
      
        def self.public_valid_options
          @public_valid_options ||=
            %i(page
      Severity: Major
      Found in lib/topic_query.rb - About 7 hrs to fix

        Method create has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
        Open

          def create
            params.require(:email)
            params.permit(:user_fields)
        
            unless SiteSetting.allow_new_registrations
        Severity: Minor
        Found in app/controllers/users_controller.rb - About 7 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method build has 178 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def build
              return @wizard unless SiteSetting.wizard_enabled? && @wizard.user.try(:staff?)
        
              @wizard.append_step('locale') do |step|
                step.banner = "welcome.png"
        Severity: Major
        Found in lib/wizard/builder.rb - About 7 hrs to fix

          Method admin_login has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
          Open

            def admin_login
              return redirect_to(path("/")) if current_user
          
              if request.put? && params[:email].present?
                RateLimiter.new(nil, "admin-login-hr-#{request.remote_ip}", 6, 1.hour).performed!
          Severity: Minor
          Found in app/controllers/users_controller.rb - About 7 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          File post_action.rb has 458 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          require_dependency 'rate_limiter'
          require_dependency 'system_message'
          
          class PostAction < ActiveRecord::Base
            class AlreadyActed < StandardError; end
          Severity: Minor
          Found in app/models/post_action.rb - About 7 hrs to fix

            File instance.rb has 455 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            require 'digest/sha1'
            require 'fileutils'
            require_dependency 'plugin/metadata'
            require_dependency 'plugin/auth_provider'
            
            
            Severity: Minor
            Found in lib/plugin/instance.rb - About 6 hrs to fix

              Method password_reset has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
              Open

                def password_reset
                  expires_now
              
                  token = params[:token]
              
              
              Severity: Minor
              Found in app/controllers/users_controller.rb - About 6 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method sso_login has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
              Open

                def sso_login
                  raise Discourse::NotFound.new unless SiteSetting.enable_sso
              
                  sso = DiscourseSingleSignOn.parse(request.query_string)
                  if !sso.nonce_valid?
              Severity: Minor
              Found in app/controllers/session_controller.rb - About 6 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method current_user has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
              Open

                def current_user
                  return @env[CURRENT_USER_KEY] if @env.key?(CURRENT_USER_KEY)
              
                  # bypass if we have the shared session header
                  if shared_key = @env['HTTP_X_SHARED_SESSION_KEY']
              Severity: Minor
              Found in lib/auth/default_current_user_provider.rb - About 6 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method create_from has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
              Open

                def self.create_from(args = {})
                  url = args[:url][0...TopicLink.max_url_length]
                  return nil if url.blank?
              
                  uri = URI.parse(url) rescue nil
              Severity: Minor
              Found in app/models/topic_link_click.rb - About 6 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Class StaffActionLogger has 46 methods (exceeds 20 allowed). Consider refactoring.
              Open

              class StaffActionLogger
              
                def self.base_attrs
                  [:topic_id, :post_id, :context, :subject, :ip_address, :previous_value, :new_value]
                end
              Severity: Minor
              Found in app/services/staff_action_logger.rb - About 6 hrs to fix

                Method html_for has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
                Open

                  def self.html_for(category, opts = nil)
                    opts = opts || {}
                
                    # If there is no category, bail
                    return "" if category.blank?
                Severity: Minor
                Found in lib/category_badge.rb - About 6 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method publish has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
                Open

                    def publish
                      data = params.permit(
                        :response_needed,
                        current: [:action, :topic_id, :post_id],
                        previous: [:action, :topic_id, :post_id]
                Severity: Minor
                Found in plugins/discourse-presence/plugin.rb - About 6 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Class Category has 45 methods (exceeds 20 allowed). Consider refactoring.
                Open

                class Category < ActiveRecord::Base
                  include Searchable
                  include Positionable
                  include HasCustomFields
                  include CategoryHashtag
                Severity: Minor
                Found in app/models/category.rb - About 6 hrs to fix

                  Class PostsController has 45 methods (exceeds 20 allowed). Consider refactoring.
                  Open

                  class PostsController < ApplicationController
                  
                    requires_login except: [
                      :show,
                      :replies,
                  Severity: Minor
                  Found in app/controllers/posts_controller.rb - About 6 hrs to fix
                    Severity
                    Category
                    Status
                    Source
                    Language