discourse/discourse

View on GitHub
lib/html_prettify.rb

Summary

Maintainability
D
2 days
Test Coverage

Method to_html has a Cognitive Complexity of 85 (exceeds 5 allowed). Consider refactoring.
Open

  def to_html
    do_quotes = do_backticks = do_dashes = do_ellipses = nil

    if @options.include?(0)
      # Do nothing.
Severity: Minor
Found in lib/html_prettify.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method to_html has 75 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def to_html
    do_quotes = do_backticks = do_dashes = do_ellipses = nil

    if @options.include?(0)
      # Do nothing.
Severity: Major
Found in lib/html_prettify.rb - About 3 hrs to fix

    Method educate_quotes has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def educate_quotes(str)
        punct_class = '[!"#\$\%\'()*+,\-.\/:;<=>?\@\[\\\\\]\^_`{|}~]'
    
        # normalize html
        str = str.dup
    Severity: Minor
    Found in lib/html_prettify.rb - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                    if prev_token_last_char =~ /\S/
                      t = entity(:single_right_quote)
                    else
                      t = entity(:single_left_quote)
                    end
      Severity: Major
      Found in lib/html_prettify.rb - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                    elsif t == '"'
                      # Special case: single-character " token
                      if prev_token_last_char =~ /\S/
                        t = entity(:double_right_quote)
                      else
        Severity: Major
        Found in lib/html_prettify.rb - About 45 mins to fix

          There are no issues that match your filters.

          Category
          Status