discourse/discourse

View on GitHub
lib/onpdiff.rb

Summary

Maintainability
D
2 days
Test Coverage

Method build_short_edit_script has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

  def build_short_edit_script(shortest_path)
    ses = []
    x, y = 1, 1
    px, py = 0, 0
    i = shortest_path.size - 1
Severity: Minor
Found in lib/onpdiff.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method build_edit_script has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

  def build_edit_script(shortest_path)
    ses = []
    x, y = 1, 1
    px, py = 0, 0
    i = shortest_path.size - 1
Severity: Minor
Found in lib/onpdiff.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method build_short_edit_script has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def build_short_edit_script(shortest_path)
    ses = []
    x, y = 1, 1
    px, py = 0, 0
    i = shortest_path.size - 1
Severity: Minor
Found in lib/onpdiff.rb - About 1 hr to fix

    Method compose has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def compose
        return @shortest_path if @shortest_path
    
        size = @m + @n + 3
        fp = Array.new(size, -1)
    Severity: Minor
    Found in lib/onpdiff.rb - About 1 hr to fix

      Method build_edit_script has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def build_edit_script(shortest_path)
          ses = []
          x, y = 1, 1
          px, py = 0, 0
          i = shortest_path.size - 1
      Severity: Minor
      Found in lib/onpdiff.rb - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                  t = @reverse ? :add : :delete
        Severity: Major
        Found in lib/onpdiff.rb - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                    t = @reverse ? :add : :delete
          Severity: Major
          Found in lib/onpdiff.rb - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                      if ses.size > 0 && ses[-1][1] == t
                        ses[-1][0] << @a[px]
                      else
                        ses << [@a[px], t]
                      end
            Severity: Major
            Found in lib/onpdiff.rb - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                        if ses.size > 0 && ses[-1][1] == :common
                          ses[-1][0] << @a[px]
                        else
                          ses << [@a[px], :common]
                        end
              Severity: Major
              Found in lib/onpdiff.rb - About 45 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                          t = @reverse ? :delete : :add
                          if ses.size > 0 && ses[-1][1] == t
                            ses[-1][0] << @b[py]
                          else
                            ses << [@b[py], t]
                Severity: Minor
                Found in lib/onpdiff.rb and 1 other location - About 50 mins to fix
                lib/onpdiff.rb on lines 134..142

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 43.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                          t = @reverse ? :add : :delete
                          if ses.size > 0 && ses[-1][1] == t
                            ses[-1][0] << @a[px]
                          else
                            ses << [@a[px], t]
                Severity: Minor
                Found in lib/onpdiff.rb and 1 other location - About 50 mins to fix
                lib/onpdiff.rb on lines 125..133

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 43.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      while k <= @delta - 1
                        fp[k + @offset] = snake(k, fp[k - 1 + @offset] + 1, fp[k + 1 + @offset])
                        k += 1
                      end
                Severity: Minor
                Found in lib/onpdiff.rb and 1 other location - About 35 mins to fix
                lib/onpdiff.rb on lines 50..53

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 34.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      while k >= @delta + 1
                        fp[k + @offset] = snake(k, fp[k - 1 + @offset] + 1, fp[k + 1 + @offset])
                        k -= 1
                      end
                Severity: Minor
                Found in lib/onpdiff.rb and 1 other location - About 35 mins to fix
                lib/onpdiff.rb on lines 44..47

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 34.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status