discourse/discourse

View on GitHub
plugins/discourse-narrative-bot/lib/discourse_narrative_bot/new_user_narrative.rb

Summary

Maintainability
D
2 days
Test Coverage

File new_user_narrative.rb has 408 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'distributed_mutex'

module DiscourseNarrativeBot
  class NewUserNarrative < Base
    I18N_KEY = "discourse_narrative_bot.new_user_narrative".freeze

    Class NewUserNarrative has 22 methods (exceeds 20 allowed). Consider refactoring.
    Open

      class NewUserNarrative < Base
        I18N_KEY = "discourse_narrative_bot.new_user_narrative".freeze
        BADGE_NAME = 'Certified'.freeze
    
        TRANSITION_TABLE = {

      Method reply_to_image has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          def reply_to_image
            post_topic_id = @post.topic_id
            return unless valid_topic?(post_topic_id)
      
            transition = true

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method reply_to_image has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def reply_to_image
            post_topic_id = @post.topic_id
            return unless valid_topic?(post_topic_id)
      
            transition = true

        Method say_hello has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def say_hello
              raw = I18n.t(
                "#{I18N_KEY}.hello.message",
                i18n_post_args(
                  username: @user.username,

          Method reply_to_onebox has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              def reply_to_onebox
                post_topic_id = @post.topic_id
                return unless valid_topic?(post_topic_id)
          
                @post.post_analyzer.cook(@post.raw, {})

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method reply_to_emoji has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              def reply_to_emoji
                post_topic_id = @post.topic_id
                return unless valid_topic?(post_topic_id)
          
                doc = Nokogiri::HTML.fragment(@post.cooked)

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method reply_to_search has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              def reply_to_search
                post_topic_id = @post.topic_id
                return unless valid_topic?(post_topic_id)
          
                if @post.raw.match(/#{SEARCH_ANSWER}/)

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method reply_to_mention has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              def reply_to_mention
                post_topic_id = @post.topic_id
                return unless valid_topic?(post_topic_id)
          
                if bot_mentioned?(@post)

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method reply_to_formatting has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              def reply_to_formatting
                post_topic_id = @post.topic_id
                return unless valid_topic?(post_topic_id)
          
                if Nokogiri::HTML.fragment(@post.cooked).css("b", "strong", "em", "i", ".bbcode-i", ".bbcode-b").size > 0

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method reply_to_quote has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              def reply_to_quote
                post_topic_id = @post.topic_id
                return unless valid_topic?(post_topic_id)
          
                doc = Nokogiri::HTML.fragment(@post.cooked)

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method track_like has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def track_like
                post_topic_id = @post.topic_id
                return unless valid_topic?(post_topic_id)
          
                post_liked = PostAction.find_by(

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def reply_to_quote
                post_topic_id = @post.topic_id
                return unless valid_topic?(post_topic_id)
          
                doc = Nokogiri::HTML.fragment(@post.cooked)
          plugins/discourse-narrative-bot/lib/discourse_narrative_bot/new_user_narrative.rb on lines 405..427

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 65.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def reply_to_emoji
                post_topic_id = @post.topic_id
                return unless valid_topic?(post_topic_id)
          
                doc = Nokogiri::HTML.fragment(@post.cooked)
          plugins/discourse-narrative-bot/lib/discourse_narrative_bot/new_user_narrative.rb on lines 379..401

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 65.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              def reset_bot(user, post)
                if pm_to_bot?(post)
                  reset_data(user, topic_id: post.topic_id)
                else
                  reset_data(user)
          plugins/discourse-narrative-bot/lib/discourse_narrative_bot/advanced_user_narrative.rb on lines 105..112

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 26.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status