discourse/discourse

View on GitHub
plugins/poll/spec/lib/polls_validator_spec.rb

Summary

Maintainability
C
1 day
Test Coverage

File polls_validator_spec.rb has 275 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require "rails_helper"

describe ::DiscoursePoll::PollsValidator do
  let(:post) { Fabricate(:post) }
  subject { described_class.new(post) }
Severity: Minor
Found in plugins/poll/spec/lib/polls_validator_spec.rb - About 2 hrs to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        it "ensure that polls have unique options" do
          raw = <<~RAW
          [poll]
          * 1
          * 1
    Severity: Major
    Found in plugins/poll/spec/lib/polls_validator_spec.rb and 3 other locations - About 1 hr to fix
    plugins/poll/spec/lib/polls_validator_spec.rb on lines 55..91
    plugins/poll/spec/lib/polls_validator_spec.rb on lines 125..149
    plugins/poll/spec/lib/polls_validator_spec.rb on lines 190..218

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        it "ensure that polls have at least 2 options" do
          raw = <<~RAW
          [poll]
          * 1
          [/poll]
    Severity: Major
    Found in plugins/poll/spec/lib/polls_validator_spec.rb and 3 other locations - About 1 hr to fix
    plugins/poll/spec/lib/polls_validator_spec.rb on lines 55..91
    plugins/poll/spec/lib/polls_validator_spec.rb on lines 95..121
    plugins/poll/spec/lib/polls_validator_spec.rb on lines 190..218

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        it "ensure that polls have unique names" do
          raw = <<~RAW
          [poll]
          * 1
          * 2
    Severity: Major
    Found in plugins/poll/spec/lib/polls_validator_spec.rb and 3 other locations - About 1 hr to fix
    plugins/poll/spec/lib/polls_validator_spec.rb on lines 95..121
    plugins/poll/spec/lib/polls_validator_spec.rb on lines 125..149
    plugins/poll/spec/lib/polls_validator_spec.rb on lines 190..218

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

          it "ensure that min < max" do
            raw = <<~RAW
            [poll type=multiple min=2 max=1]
            * 1
            * 2
    Severity: Major
    Found in plugins/poll/spec/lib/polls_validator_spec.rb and 3 other locations - About 1 hr to fix
    plugins/poll/spec/lib/polls_validator_spec.rb on lines 55..91
    plugins/poll/spec/lib/polls_validator_spec.rb on lines 95..121
    plugins/poll/spec/lib/polls_validator_spec.rb on lines 125..149

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

          it "ensure max > 0" do
            raw = <<~RAW
            [poll type=multiple max=-2]
            * 1
            * 2
    Severity: Minor
    Found in plugins/poll/spec/lib/polls_validator_spec.rb and 4 other locations - About 15 mins to fix
    plugins/poll/spec/lib/polls_validator_spec.rb on lines 238..250
    plugins/poll/spec/lib/polls_validator_spec.rb on lines 254..266
    plugins/poll/spec/lib/polls_validator_spec.rb on lines 282..294
    plugins/poll/spec/lib/polls_validator_spec.rb on lines 298..310

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

          it "ensure that min != number of options" do
            raw = <<~RAW
            [poll type=multiple min=2]
            * 1
            * 2
    Severity: Minor
    Found in plugins/poll/spec/lib/polls_validator_spec.rb and 4 other locations - About 15 mins to fix
    plugins/poll/spec/lib/polls_validator_spec.rb on lines 222..234
    plugins/poll/spec/lib/polls_validator_spec.rb on lines 238..250
    plugins/poll/spec/lib/polls_validator_spec.rb on lines 254..266
    plugins/poll/spec/lib/polls_validator_spec.rb on lines 298..310

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

          it "ensure that max <= number of options" do
            raw = <<~RAW
            [poll type=multiple max=3]
            * 1
            * 2
    Severity: Minor
    Found in plugins/poll/spec/lib/polls_validator_spec.rb and 4 other locations - About 15 mins to fix
    plugins/poll/spec/lib/polls_validator_spec.rb on lines 222..234
    plugins/poll/spec/lib/polls_validator_spec.rb on lines 254..266
    plugins/poll/spec/lib/polls_validator_spec.rb on lines 282..294
    plugins/poll/spec/lib/polls_validator_spec.rb on lines 298..310

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

          it "ensure that min < number of options" do
            raw = <<~RAW
            [poll type=multiple min=3]
            * 1
            * 2
    Severity: Minor
    Found in plugins/poll/spec/lib/polls_validator_spec.rb and 4 other locations - About 15 mins to fix
    plugins/poll/spec/lib/polls_validator_spec.rb on lines 222..234
    plugins/poll/spec/lib/polls_validator_spec.rb on lines 238..250
    plugins/poll/spec/lib/polls_validator_spec.rb on lines 254..266
    plugins/poll/spec/lib/polls_validator_spec.rb on lines 282..294

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

          it "ensure that min >= 0" do
            raw = <<~RAW
            [poll type=multiple min=-1]
            * 1
            * 2
    Severity: Minor
    Found in plugins/poll/spec/lib/polls_validator_spec.rb and 4 other locations - About 15 mins to fix
    plugins/poll/spec/lib/polls_validator_spec.rb on lines 222..234
    plugins/poll/spec/lib/polls_validator_spec.rb on lines 238..250
    plugins/poll/spec/lib/polls_validator_spec.rb on lines 282..294
    plugins/poll/spec/lib/polls_validator_spec.rb on lines 298..310

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status