divio/django-cms

View on GitHub
cms/cache/placeholder.py

Summary

Maintainability
B
5 hrs
Test Coverage

Function _set_placeholder_cache_version has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

def _set_placeholder_cache_version(placeholder, lang, site_id, version, vary_on_list=None, duration=None):
Severity: Minor
Found in cms/cache/placeholder.py - About 45 mins to fix

    Function _get_placeholder_cache_key has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def _get_placeholder_cache_key(placeholder, lang, site_id, request, soft=False):
    Severity: Minor
    Found in cms/cache/placeholder.py - About 35 mins to fix

      Function set_placeholder_cache has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def set_placeholder_cache(placeholder, lang, site_id, content, request):
      Severity: Minor
      Found in cms/cache/placeholder.py - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if len(key) > 250:
                key = '{prefix}|{hash}'.format(
                    prefix=prefix,
                    hash=hashlib.sha1(key.encode('utf-8')).hexdigest(),
        Severity: Major
        Found in cms/cache/placeholder.py and 1 other location - About 1 hr to fix
        cms/cache/placeholder.py on lines 131..134

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if len(cache_key) > 250:
                cache_key = '{prefix}|{hash}'.format(
                    prefix=prefix,
                    hash=hashlib.sha1(cache_key.encode('utf-8')).hexdigest(),
        Severity: Major
        Found in cms/cache/placeholder.py and 1 other location - About 1 hr to fix
        cms/cache/placeholder.py on lines 47..50

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status