Sign upLogin

divio/django-cms

View on GitHub
Star
cms/static/cms/js/modules/cms.toolbar.js

Summary

Maintainability
D
2 days
Test Coverage

File cms.toolbar.js has 493 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright https://github.com/divio/django-cms
 */

import $ from 'jquery';
Severity: Minor
Found in cms/static/cms/js/modules/cms.toolbar.js - About 7 hrs to fix

    Function _events has 194 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        _events: function _events() {
        var that = this;
        var LONG_MENUS_THROTTLE = 10;

        // attach event to the navigation elements
    Severity: Major
    Found in cms/static/cms/js/modules/cms.toolbar.js - About 7 hrs to fix

      Function _delegate has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          _delegate: function _delegate(el) {
        // save local vars
        var target = el.data('rel');

        if (el.hasClass('cms-btn-disabled')) {
      Severity: Minor
      Found in cms/static/cms/js/modules/cms.toolbar.js - About 1 hr to fix

        Function _initialStates has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            _initialStates: function _initialStates() {
        var publishBtn = $('.cms-btn-publish').parent();

        this._show({ duration: 0 });
        Severity: Minor
        Found in cms/static/cms/js/modules/cms.toolbar.js - About 1 hr to fix

          Function openAjax has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              openAjax: function(opts) {
        var that = this;
        // url, post, text, callback, onSuccess
        var url = opts.url;
        var post = opts.post || '{}';
          Severity: Minor
          Found in cms/static/cms/js/modules/cms.toolbar.js - About 1 hr to fix

            Function _initialStates has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                _initialStates: function _initialStates() {
        var publishBtn = $('.cms-btn-publish').parent();

        this._show({ duration: 0 });
            Severity: Minor
            Found in cms/static/cms/js/modules/cms.toolbar.js - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function _handleLongMenus has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                _handleLongMenus: function _handleLongMenus() {
        var openMenus = $('.cms-toolbar-item-navigation-hover > ul');

        if (!openMenus.length) {
            this._stickToolbar();
            Severity: Minor
            Found in cms/static/cms/js/modules/cms.toolbar.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                                if (
                        e.keyCode === KEYS.CMD_LEFT ||
                        e.keyCode === KEYS.CMD_RIGHT ||
                        e.keyCode === KEYS.CMD_FIREFOX ||
                        e.keyCode === KEYS.SHIFT ||
            Severity: Major
            Found in cms/static/cms/js/modules/cms.toolbar.js and 1 other location - About 2 hrs to fix
            cms/static/cms/js/modules/cms.structureboard.js on lines 208..216

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 78.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status