django/django

View on GitHub
django/contrib/admin/templatetags/admin_list.py

Summary

Maintainability
F
3 days
Test Coverage

Function items_for_result has a Cognitive Complexity of 56 (exceeds 5 allowed). Consider refactoring.
Open

def items_for_result(cl, result, form):
    """
    Generate the actual list of data.
    """

Severity: Minor
Found in django/contrib/admin/templatetags/admin_list.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File admin_list.py has 401 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import datetime

from django.contrib.admin.templatetags.admin_urls import add_preserved_filters
from django.contrib.admin.utils import (
    display_for_field, display_for_value, label_for_field, lookup_field,
Severity: Minor
Found in django/contrib/admin/templatetags/admin_list.py - About 5 hrs to fix

    Function result_headers has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
    Open

    def result_headers(cl):
        """
        Generate the list column headers.
        """
        ordering_field_columns = cl.get_ordering_field_columns()
    Severity: Minor
    Found in django/contrib/admin/templatetags/admin_list.py - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function date_hierarchy has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

    def date_hierarchy(cl):
        """
        Display the date hierarchy for date drill-down functionality.
        """
        if cl.date_hierarchy:
    Severity: Minor
    Found in django/contrib/admin/templatetags/admin_list.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function pagination has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

    def pagination(cl):
        """
        Generate the series of links to the pages in a paginated list.
        """
        paginator, page_num = cl.paginator, cl.page_num
    Severity: Minor
    Found in django/contrib/admin/templatetags/admin_list.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                        if date_range['first'].month == date_range['last'].month:
                            month_lookup = date_range['first'].month
    
    
    Severity: Major
    Found in django/contrib/admin/templatetags/admin_list.py - About 45 mins to fix

      Function results has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      def results(cl):
          if cl.formset:
              for res, form in zip(cl.result_list, cl.formset.forms):
                  yield ResultList(form, items_for_result(cl, res, form))
          else:
      Severity: Minor
      Found in django/contrib/admin/templatetags/admin_list.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function result_hidden_fields has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      def result_hidden_fields(cl):
          if cl.formset:
              for res, form in zip(cl.result_list, cl.formset.forms):
                  if form[cl.model._meta.pk.name].is_hidden:
                      yield mark_safe(form[cl.model._meta.pk.name])
      Severity: Minor
      Found in django/contrib/admin/templatetags/admin_list.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status