django/django

View on GitHub
django/contrib/gis/db/backends/postgis/operations.py

Summary

Maintainability
D
2 days
Test Coverage

File operations.py has 301 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import re

from django.conf import settings
from django.contrib.gis.db.backends.base.operations import (
    BaseSpatialOperations,
Severity: Minor
Found in django/contrib/gis/db/backends/postgis/operations.py - About 3 hrs to fix

    PostGISOperations has 23 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class PostGISOperations(BaseSpatialOperations, DatabaseOperations):
        name = 'postgis'
        postgis = True
        geography = True
        geom_func_prefix = 'ST_'
    Severity: Minor
    Found in django/contrib/gis/db/backends/postgis/operations.py - About 2 hrs to fix

      Function check_raster has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          def check_raster(self, lookup, template_params):
              spheroid = lookup.rhs_params and lookup.rhs_params[-1] == 'spheroid'
      
              # Check which input is a raster.
              lhs_is_raster = lookup.lhs.field.geom_type == 'RASTER'
      Severity: Minor
      Found in django/contrib/gis/db/backends/postgis/operations.py - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function get_distance has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def get_distance(self, f, dist_val, lookup_type):
              """
              Retrieve the distance parameters for the given geometry field,
              distance lookup value, and the distance lookup type.
      
      
      Severity: Minor
      Found in django/contrib/gis/db/backends/postgis/operations.py - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function get_geom_placeholder has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def get_geom_placeholder(self, f, value, compiler):
              """
              Provide a proper substitution value for Geometries or rasters that are
              not in the SRID of the field. Specifically, this routine will
              substitute in the ST_Transform() function call.
      Severity: Minor
      Found in django/contrib/gis/db/backends/postgis/operations.py - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function geo_db_type has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def geo_db_type(self, f):
              """
              Return the database field type for the given spatial field.
              """
              if f.geom_type == 'RASTER':
      Severity: Minor
      Found in django/contrib/gis/db/backends/postgis/operations.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if lookup.band_rhs is not None and rhs_is_raster:
                  if not self.func:
                      raise ValueError('Band indices are not allowed for this operator, it works on bbox only.')
                  template_params['rhs'] = '%s, %s' % (template_params['rhs'], lookup.band_rhs)
      Severity: Major
      Found in django/contrib/gis/db/backends/postgis/operations.py and 1 other location - About 3 hrs to fix
      django/contrib/gis/db/backends/postgis/operations.py on lines 56..59

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if lookup.band_lhs is not None and lhs_is_raster:
                  if not self.func:
                      raise ValueError('Band indices are not allowed for this operator, it works on bbox only.')
                  template_params['lhs'] = '%s, %s' % (template_params['lhs'], lookup.band_lhs)
      Severity: Major
      Found in django/contrib/gis/db/backends/postgis/operations.py and 1 other location - About 3 hrs to fix
      django/contrib/gis/db/backends/postgis/operations.py on lines 61..64

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status